feat(perms): slot manager between viewer and developer in rank

Author: Ripwords

apps/dashboard/server/lib/permissions.test.ts

@@ -2,22 +2,31 @@ import { describe, expect, test } from "bun:test"
 import { compareRole, type ProjectRoleName } from "./permissions"
 
 describe("compareRole", () => {
-  const roles: ProjectRoleName[] = ["viewer", "developer", "owner"]
+  const roles: ProjectRoleName[] = ["viewer", "manager", "developer", "owner"]
 
   test("owner satisfies all minimums", () => {
     for (const min of roles) {
       expect(compareRole("owner", min)).toBe(true)
     }
   })
 
-  test("developer satisfies developer and viewer, not owner", () => {
+  test("developer satisfies developer, manager, and viewer, not owner", () => {
     expect(compareRole("developer", "viewer")).toBe(true)
+    expect(compareRole("developer", "manager")).toBe(true)
     expect(compareRole("developer", "developer")).toBe(true)
     expect(compareRole("developer", "owner")).toBe(false)
   })
 
+  test("manager satisfies manager and viewer, not developer or owner", () => {
+    expect(compareRole("manager", "viewer")).toBe(true)
+    expect(compareRole("manager", "manager")).toBe(true)
+    expect(compareRole("manager", "developer")).toBe(false)
+    expect(compareRole("manager", "owner")).toBe(false)
+  })
+
   test("viewer satisfies only viewer", () => {
     expect(compareRole("viewer", "viewer")).toBe(true)
+    expect(compareRole("viewer", "manager")).toBe(false)
     expect(compareRole("viewer", "developer")).toBe(false)
     expect(compareRole("viewer", "owner")).toBe(false)
   })

apps/dashboard/server/lib/permissions.ts

@@ -5,12 +5,13 @@ import { db } from "../db"
 import { projectMembers } from "../db/schema"
 import { auth } from "./auth"
 
-export type ProjectRoleName = "viewer" | "developer" | "owner"
+export type ProjectRoleName = "viewer" | "manager" | "developer" | "owner"
 
 const ROLE_RANK: Record<ProjectRoleName, number> = {
   viewer: 1,
-  developer: 2,
-  owner: 3,
+  manager: 2,
+  developer: 3,
+  owner: 4,
 }
 
 export function compareRole(actual: ProjectRoleName, min: ProjectRoleName): boolean {