feat(trace): add stop callback

Author: dszakallas

lib/trace.js

@@ -10,7 +10,11 @@ var traceNoop = {
   sendMemorySnapshot: function () {},
   recordMetric: function () {},
   incrementMetric: function () {},
-  stop: function () {}
+  stop: function (cb) {
+    if (typeof cb === 'function') {
+      cb()
+    }
+  }
 }
 
 function Trace (config) {
@@ -63,8 +67,11 @@ Trace.prototype.recordMetric = function (name, value) {
   this._agent.customMetrics.record(name, value)
 }
 
-Trace.prototype.stop = function () {
+Trace.prototype.stop = function (cb) {
   this._agent._stopAll()
+  if (typeof cb === 'function') {
+    cb()
+  }
 }
 
 module.exports.Trace = Trace

test/e2e/initialization.spec.js

@@ -75,3 +75,27 @@ test('should get service key',
     })
     require('@risingstack/trace')
   })
+
+test('should stop', {
+  isolate: 'child-process',
+  childProcessOpts: {
+    env: {
+      TRACE_API_KEY: TRACE_API_KEY,
+      TRACE_SERVICE_NAME: TRACE_SERVICE_NAME,
+      TRACE_COLLECT_INTERVAL: 100
+    }
+  }
+}, function (t) {
+  t.plan(1)
+  serviceMocks.mockServiceKeyRequest({
+    url: TRACE_COLLECTOR_API_URL,
+    apiKey: TRACE_API_KEY,
+    callback: function (uri, requestBody) {
+    }
+  })
+  var trace = require('@risingstack/trace')
+  trace.stop(function (err) {
+    t.notOk(err, 'no error')
+    t.end()
+  })
+})