Skip to content

Conversation

@ctf0
Copy link

@ctf0 ctf0 commented Apr 23, 2018

according to

vue-ls/dist/vue-ls.js

Lines 176 to 195 in 6f05098

/**
* Set item
*
* @param {string} name
* @param {*} value
* @param {number} expire - seconds
*/
}, {
key: 'set',
value: function set(name, value) {
var expire = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : null;
var stringifyValue = JSON.stringify({
value: value,
expire: expire !== null ? new Date().getTime() + expire : null
});
this.storage.setItem(this.options.namespace + name, stringifyValue);
}

the expire should be in seconds in not in milli

Further Testing

without the 1000 u will get a one hour less, so it have to be in milli, maybe we should update the code docs instead

@coveralls
Copy link

coveralls commented Apr 23, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 9781c2f on ctf0:patch-2 into 6f05098 on RobinCK:master.

@ctf0 ctf0 closed this Apr 23, 2018
@ctf0 ctf0 deleted the patch-2 branch April 23, 2018 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants