[workspace] Don't build libsdformat's URDF parser #16772
Conversation
jwnimmer-tri
added
priority: low
release notes: fix
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee EricCousineau-TRI(platform) (waiting on @EricCousineau-TRI and @jwnimmer-tri)
tools/workspace/sdformat/patches/no_urdf.patch, line 1 at r1 (raw file):
Disable transmorification of URDF files into SDFormat files.
typo
Code quote:
transmorification
Drake has its own URDF parser that we must always use, so we should disable transmogrification of URDF files into SDFormat files. Don't generate sdf/sdf.hh; it's only effect is IWYU violations.
jwnimmer-tri
force-pushed
the
sdformat-no-uberheader
branch
from
87d686a
to
ed814a8
Compare
There was a problem hiding this comment.
-@EricCousineau-TRI +@sherm1 for platform review per schedule (tomorrow), please.
\CC @sammy-tri FYI for awareness.
Reviewable status: LGTM missing from assignee sherm1(platform) (waiting on @rpoyner-tri and @sherm1)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee sherm1(platform) (waiting on @sherm1)
There was a problem hiding this comment.
Platform 
Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sherm1(platform) (waiting on @jwnimmer-tri)
tools/workspace/sdformat/patches/no_urdf.patch, line 14 at r2 (raw file):
-#include "parser_urdf.hh" +// #include "parser_urdf.hh"
BTW trailing blanks
tools/workspace/sdformat/patches/no_urdf.patch, line 30 at r2 (raw file):
} +#endif // Disable URDF2SDF for Drake.
BTW trailing blanks
tools/workspace/sdformat/patches/no_urdf.patch, line 46 at r2 (raw file):
} +#endif // Disable URDF2SDF for Drake.
BTW trailing blanks
There was a problem hiding this comment.
Those blanks are how diff and patch work by default, so I'm going to leave them alone.
Reviewable status:
|
Thanks! \cc @azeey |
Drake has its own URDF parser that we must always use, so we should disable libsdformat's automatic transmogrification of URDF files into SDFormat files.
Don't generate
sdf/sdf.hh; it's only effect is IWYU violations.Towards #12610.
+@rpoyner-tri for feature review, please.
+@EricCousineau-TRI for platform review (as SME), please.
Should we have anyone from OpenRobotics take a look here as well?
This change is