Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visualization] Fix depth colorization to use brighter for nearer #20940

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Feb 13, 2024

This matches what the docs promised. We got it backwards when porting the Python colorizer down to C++ (#20488).


This change is Reviewable

This matches what the docs promised. We got it backwards when porting
the Python colorizer down to C++.
@jwnimmer-tri jwnimmer-tri added priority: medium status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Feb 13, 2024
@jwnimmer-tri
Copy link
Collaborator Author

+@SeanCurtis-TRI for both(?) reviews, please.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM: X2

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)

@jwnimmer-tri jwnimmer-tri merged commit 42c9a8f into RobotLocomotion:master Feb 13, 2024
9 checks passed
@jwnimmer-tri jwnimmer-tri deleted the colorize-depth-brighter branch February 13, 2024 20:38
jwnimmer-tri added a commit to jwnimmer-tri/drake that referenced this pull request Apr 1, 2024
…botLocomotion#20940)

This matches what the docs promised. We got it backwards when porting
the Python colorizer down to C++.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants