Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename drake/examples/Cars to drake/automotive #3436

Merged
merged 7 commits into from
Sep 13, 2016

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Sep 13, 2016

Closes #3406.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

+@rpoyner-tri for feature review, please.

@jwnimmer-tri
Copy link
Collaborator Author

This PR moves the files and updates all path references. A subsequent PR will deal with updating the C++ namespaces and any other loose ends.

@jwnimmer-tri
Copy link
Collaborator Author

+@david-german-tri for platform review, please.
(Doing the reviews concurrently to get this in ASAP; it's very conflict-prone.)

@david-german-tri
Copy link
Contributor

@drake-jenkins-bot linux-clang-experimental-ros please

otherwise :lgtm:


Review status: 0 of 78 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@david-german-tri
Copy link
Contributor

Reviewed 148 of 148 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@rpoyner-tri
Copy link
Contributor

Ah, just saw your comment above about further loose ends, such as "drakeCars" and "drake_cars" in various places.

:lgtm:


Reviewed 148 of 148 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

Ah bummer, of course the ROS build is going to fail. I always forget that.

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot linux-clang-experimental-ros please

@rpoyner-tri
Copy link
Contributor

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

Wow. Three hours from starting typing to a merge. Possibly a new personal best.

@jwnimmer-tri jwnimmer-tri merged commit 2940096 into RobotLocomotion:master Sep 13, 2016
@jwnimmer-tri jwnimmer-tri deleted the automotive-rename branch September 14, 2016 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants