Run the cpp/py client sequentially #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, we launched the cpp and python client simultaneously, but it seems that the request is never sent on Windows CI(appveyor) which leads a timeout of 60000ms. So we will launch the two clients (cpp and python) one by one.
Member
Author
|
@qiuzhong I meet this problem on appveyor (https://ci.appveyor.com/project/minggangw/rclnodejs/build/develop-133) recently after e943cfe and windows only, I submit this pr to change the way of launching the client, would you please have a look to see whether it's reasonable? |
Collaborator
|
@minggangw , I met this problem too when I submitted last PR for the first time CI on Windows. Linux and macOS were fine. However, for the second CI all passed. I have no idea why this happened. |
Collaborator
|
@minggangw , it's OK for me so long as the CI can pass easily! |
Member
Author
|
Thanks, I will merge the pr soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, we launched the cpp and python client simultaneously, but it
seems that the request is never sent on Windows CI(appveyor)
which leads a timeout of 60000ms. So we will launch the two clients
(cpp and python) one by one.