make publisher be able to take-in a plain JavaScript object as messag… #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to be published
Member
Author
|
This is the kinda precondition of #189 , the purpose is to enable publisher to be able to take-in plain JavaScript objects as arguments. These plain JavaScript objects are easier to be used than ROS message wrapper instances. |
minggangw
approved these changes
Nov 23, 2017
Member
minggangw
left a comment
minggangw
left a comment
There was a problem hiding this comment.
For the file lib/message-translator.js, we'd better use the underscore in the name of source files to align with the existing ones, others LGTM, thanks!
kenny-y
force-pushed
the
take-in-javascript-object-as-message
branch
from
685e500 to
32ab91b
Compare
…or files under /lib dir
Member
Author
|
Push it again to trigger all CIs... AppVeyor failed for the previous push but there was no change to the functionality. So I'd like to trigger it again and see what happens. |
Member
Author
|
AppVeyor works this time but Travis is complaining... |
Member
Author
|
Finally all CIs work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e to be published