Enable strictPropertyInitialization (#1046)

Author: EzraBrooks

src/actionlib/SimpleActionServer.ts

@@ -38,7 +38,7 @@ export default class SimpleActionServer<
     result?: TResult;
     status: actionlib_msgs.GoalStatus;
   }>;
-  statusPublisher: Topic<actionlib_msgs.GoalStatusArray>;
+  statusPublisher?: Topic<actionlib_msgs.GoalStatusArray>;
   statusMessage: actionlib_msgs.GoalStatusArray;
   /**
    * @param options

src/core/Topic.ts

@@ -42,8 +42,8 @@ export default class Topic<T> extends EventEmitter<{
   callForSubscribeAndAdvertise: (
     message: RosbridgeSubscribeMessage | RosbridgeAdvertiseMessage,
   ) => void;
-  subscribeId: string | null;
-  advertiseId: string;
+  subscribeId: string | null = null;
+  advertiseId?: string;
   /**
    * @param options
    * @param options.ros - The ROSLIB.Ros connection handle.

src/tf/ROS2TFClient.ts

@@ -12,7 +12,7 @@ export default class ROS2TFClient extends BaseTFClient {
     tf2_web_republisher.TFSubscriptionResult,
     tf2_web_republisher.TFSubscriptionFeedback
   >;
-  currentGoal: tf2_web_republisher.TFSubscriptionGoal;
+  currentGoal?: tf2_web_republisher.TFSubscriptionGoal;
 
   constructor(options: ConstructorParameters<typeof BaseTFClient>[0]) {
     super(options);

tsconfig.build.json

@@ -41,14 +41,14 @@
     "strictBindCallApply": true /* Check that the arguments for `bind`, `call`, and `apply` methods match the original function. */,
     "strictBuiltinIteratorReturn": true /* Built-in iterators are instantiated with a 'TReturn' type of 'undefined' instead of 'any'. */,
     "useUnknownInCatchVariables": true /* Default catch clause variables as `unknown` instead of `any`. */,
+    "strictPropertyInitialization": true /* Check for class properties that are declared but not set in the constructor. */,
     "noImplicitOverride": true /* Ensure overriding members in derived classes are marked with an override modifier. */,
 
     /* Rules to be enabled */
     "exactOptionalPropertyTypes": false /* Differentiate between undefined and not present when type checking */,
     "noImplicitAny": false /* Enable error reporting for expressions and declarations with an implied 'any' type. */,
     "noUncheckedIndexedAccess": false /* Add `undefined` to a type when accessed using an index. */,
     "strictFunctionTypes": false /* When assigning functions, check to ensure parameters and the return values are subtype-compatible. */,
-    "strictPropertyInitialization": false /* Check for class properties that are declared but not set in the constructor. */,
 
     "types": ["@types/node"]
   },