Add support for load/unload worlds; add full list of features #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jhanca-robotecai
commented
Oct 10, 2025
jhanca-robotecai
commented
- add support for worlds in q_simulation_interfaces
- add all missing features to the list, so it can parse the output from simulator
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
arturkamieniecki
approved these changes
Oct 20, 2025
Comment on lines
337
to
340
| if (!getCurrentWorldService_) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
All other service handlers produce a warning if the service is not present.
| const QString worldStr = useUriForWorlds_ | ||
| ? QString::fromStdString(response->world.world_resource.uri) | ||
| : QString::fromStdString(response->world.world_resource.resource_string); | ||
| ui_->currentWorldLabel->setText("Current world: " + worldStr); |
There was a problem hiding this comment.
Nit (UX/UI): Won't this produce a "Current world:" when no world is selected? Maybe consider a special case for no world loaded.
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
|
Everything looks good. Just one more very minor nit pick. When launching the app, and looking at the Worlds tab, the current world is set to "". No client that supports simulation interfaces is launched at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.