Skip to content

Commit f7e36cd

Browse files
committed
Merge branch 'master' of git://github.com/wix/react-native-navigation
2 parents 024095e + 188a42e commit f7e36cd

File tree

8 files changed

+14
-37
lines changed

8 files changed

+14
-37
lines changed

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
[![NPM Version](https://img.shields.io/npm/v/react-native-navigation.svg?style=flat)](https://www.npmjs.com/package/react-native-navigation)
88
[![NPM Downloads](https://img.shields.io/npm/dm/react-native-navigation.svg?style=flat)](https://www.npmjs.com/package/react-native-navigation)
9-
[![Build Status](https://jenkins-oss.wixpress.com/buildStatus/icon?job=react-native-navigation-master)](https://jenkins-oss.wixpress.com/job/react-native-navigation-master/)
9+
[![Build Status](https://img.shields.io/jenkins/s/http/jenkins-oss.wixpress.com:8080/job/react-native-navigation-master.svg)](https://jenkins-oss.wixpress.com/job/react-native-navigation-master/)
1010
[![Join us on Discord](https://img.shields.io/badge/discord-react--native--navigation-738bd7.svg?style=flat)](https://discord.gg/DhkZjq2)
1111

1212
## Important
@@ -16,7 +16,9 @@ We are currently in late stages of development of [v2](https://github.com/wix/re
1616
* [v2 Documentation](https://wix.github.io/react-native-navigation/v2/#/)
1717
<br><br>Have any questions regarding v2? Join us in [Discord](https://discord.gg/DhkZjq2) #v2 channel.
1818

19-
<br><br>Latest stable version is `1.1.x` and is published to npm under tag `latest`. It supports react-native >= 0.48.
19+
<br><br>Latest stable version is `1.1.x` and is published to npm under tag `latest`.
20+
Version 1.1.483 supports react-native >= 0.48 up to react-native 0.56
21+
Version 1.1.484 supports react-native >= 0.57
2022
>⚠️Since we're focusing our efforts on v2, we are not accepting pull requests for v1 and are not addresing issues for v1.
2123
2224
### tl;dr

android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apply plugin: 'com.android.library'
22
apply from: '../prepare-robolectric.gradle'
33

44
android {
5-
compileSdkVersion 25
5+
compileSdkVersion 26
66
buildToolsVersion '26.0.2'
77

88
defaultConfig {

android/app/src/main/java/com/reactnativenavigation/NavigationApplication.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import com.facebook.react.ReactNativeHost;
1313
import com.facebook.react.ReactPackage;
1414
import com.facebook.react.bridge.ReactContext;
15-
import com.facebook.react.uimanager.UIImplementationProvider;
1615
import com.facebook.react.uimanager.UIManagerModule;
1716
import com.reactnativenavigation.bridge.EventEmitter;
1817
import com.reactnativenavigation.controllers.ActivityCallbacks;
@@ -35,7 +34,7 @@ public void onCreate() {
3534
super.onCreate();
3635
instance = this;
3736
handler = new Handler(getMainLooper());
38-
reactGateway = new NavigationReactGateway(getUIImplementationProvider());
37+
reactGateway = new NavigationReactGateway();
3938
eventEmitter = new EventEmitter(reactGateway);
4039
activityCallbacks = new ActivityCallbacks();
4140
}
@@ -54,11 +53,6 @@ public void startActivity(Intent intent) {
5453
}
5554
}
5655

57-
// here in case someone wants to override this
58-
protected UIImplementationProvider getUIImplementationProvider() {
59-
return null; // if null the default UIImplementationProvider will be used
60-
}
61-
6256
public void startReactContextOnceInBackgroundAndExecuteJS() {
6357
reactGateway.startReactContextOnceInBackgroundAndExecuteJS();
6458
}

android/app/src/main/java/com/reactnativenavigation/react/NavigationReactGateway.java

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import com.facebook.react.bridge.ReactContext;
1111
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
1212
import com.facebook.react.shell.MainReactPackage;
13-
import com.facebook.react.uimanager.UIImplementationProvider;
1413
import com.reactnativenavigation.NavigationApplication;
1514
import com.reactnativenavigation.bridge.NavigationReactEventEmitter;
1615
import com.reactnativenavigation.bridge.NavigationReactPackage;
@@ -29,28 +28,7 @@ public class NavigationReactGateway implements ReactGateway {
2928
private JsDevReloadHandler jsDevReloadHandler;
3029

3130
public NavigationReactGateway() {
32-
this(null);
33-
}
34-
35-
public NavigationReactGateway(final UIImplementationProvider customImplProvider) {
36-
37-
if (customImplProvider != null) {
38-
host = new ReactNativeHostImpl() {
39-
/**
40-
* This was added in case someone needs to provide a different UIImplementationProvider
41-
* @param {UIImplementationProvider} defaultProvider
42-
* @return {UIImplementationProvider}
43-
*/
44-
@Override
45-
protected UIImplementationProvider getUIImplementationProvider() {
46-
return customImplProvider;
47-
}
48-
};
49-
} else {
50-
host = new ReactNativeHostImpl();
51-
}
52-
53-
31+
host = new ReactNativeHostImpl();
5432
jsDevReloadHandler = new JsDevReloadHandler();
5533
}
5634

docs/_sidebar.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
#### V 1.1.X
2+
For [V2 docs click here](https://github.com/wix/react-native-navigation/tree/v2)
3+
14
- Getting started
25
- [Installation - iOS](/installation-ios)
36
- [Installation - Android](/installation-android)
@@ -14,4 +17,4 @@
1417
- [Styling the Navigator](/styling-the-navigator)
1518
- [Adding Buttons to the Navigator](/adding-buttons-to-the-navigator)
1619
- [Styling the Tab Bar](/styling-the-tab-bar)
17-
20+

docs/installation-android.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
1. Install `react-native-navigation` latest stable version.
66

77
```sh
8-
yarn add react-native-navigation@latest
8+
yarn add react-native-navigation@1.x.x
99
```
1010

1111
2. Add the following in `android/settings.gradle`.

docs/installation-ios.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
1. Install `react-native-navigation` latest stable version.
66

77
```sh
8-
yarn add react-native-navigation@latest
8+
yarn add react-native-navigation@1.x.x
99
```
1010

1111
2. In Xcode, in Project Navigator (left pane), right-click on the `Libraries` > `Add files to [project name]`. Add `./node_modules/react-native-navigation/ios/ReactNativeNavigation.xcodeproj` ([screenshots](https://facebook.github.io/react-native/docs/0.54/linking-libraries-ios.html#step-1-1))

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-navigation",
3-
"version": "1.1.406",
3+
"version": "1.1.486",
44
"description": "React Native Navigation - truly native navigation for iOS and Android",
55
"license": "MIT",
66
"nativePackage": true,

0 commit comments

Comments
 (0)