-
-
Notifications
You must be signed in to change notification settings - Fork 214
ENH: Add save functionality to _MonteCarloPlots.all method #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add save functionality to _MonteCarloPlots.all method #884
Conversation
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
|
@copilot please add this PR to the CHANGELOG.md file! |
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #884 +/- ##
===========================================
+ Coverage 80.27% 80.37% +0.09%
===========================================
Files 104 106 +2
Lines 12769 13007 +238
===========================================
+ Hits 10250 10454 +204
- Misses 2519 2553 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
Pull request type
Checklist
black rocketpy/ tests/) has passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
_MonteCarloPlots.all()can only display histograms interactively. No option to save to disk, unlikeellipses(save=True)and other plot methods in RocketPy that supportfilenameparameter.New behavior
Added
filenameparameter to_MonteCarloPlots.all()following the established pattern used in_FlightPlots:show_or_save_plot()helper for consistent behaviorhistogram.png→histogram_apogee.png)Breaking change
Additional information
Closes #761
Also refactored
_post_test_file_cleanup()in test file to use list-based approach for maintainability.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.