Skip to content

fix: list_exists refactor message #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix: list_exists refactor message #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b1505f
refactor: message
yogyrton Dec 26, 2024
1d35447
refactor: message
yogyrton Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/HelpersServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@ protected function extendValidator(): void

Validator::extend('list_exists', function ($attribute, $value, $parameters, $validator) {
if (count($parameters) < 1) {
throw new InvalidValidationRuleUsageException('You must add at least 1 parameter.');
throw new InvalidValidationRuleUsageException("list_exists: At least 1 parameter must be added when checking the {$attribute} field in the request.");
}

$hasFieldNameParam = !empty(Arr::get($parameters, 2));

if (is_multidimensional($value) && !$hasFieldNameParam) {
throw new InvalidValidationRuleUsageException('The third argument should be filled for collections input.');
throw new InvalidValidationRuleUsageException("list_exists: The third parameter should be filled when checking the {$attribute} field if we are using a collection in request.");
}

if ($hasFieldNameParam) {
Expand Down
4 changes: 2 additions & 2 deletions tests/ValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public function testListExistsFailedValidation()
public function testListExistsWithoutArgs()
{
$this->expectException(InvalidValidationRuleUsageException::class);
$this->expectExceptionMessage('You must add at least 1 parameter.');
$this->expectExceptionMessage('list_exists: At least 1 parameter must be added when checking the ids field in the request.');

$validator = Validator::make(
['ids' => [1, 2, 3]],
Expand All @@ -149,7 +149,7 @@ public function testListExistsWithoutArgs()
public function testListExistsIncorrectParameters()
{
$this->expectException(InvalidValidationRuleUsageException::class);
$this->expectExceptionMessage('The third argument should be filled for collections input.');
$this->expectExceptionMessage('The third parameter should be filled when checking the ids field if we are using a collection in request.');

$validator = Validator::make(
[
Expand Down
Loading