Tool (write_to_file/apply_diff/etc..) execution results in false failure due to improper handling of Java diagnostics error

[HarukiKosuda2930]

App Version

3.11.12

API Provider

Ollama

Model Used

qwen2.5-coder

Actual vs. Expected Behavior

Even when write_to_file successfully updates a file, an error is still reported.

In the getNewDiagnostics function located at src\integrations\diagnostics\index.ts, issues are retrieved after rewriting the file. However, the function does not expect a folder path to be returned and tries to open it as a document, which results in an exception.
Although the file is updated successfully, an error is reported to the LLM, causing it to become confused and unable to proceed with the task.

src\integrations\diagnostics\index.ts 96-

					case vscode.DiagnosticSeverity.Hint:
						label = "Hint"
						break
					default:
						label = "Diagnostic"
				}
				const line = diagnostic.range.start.line + 1 // VSCode lines are 0-indexed
				const source = diagnostic.source ? `${diagnostic.source} ` : ""
				const document = documents.get(uri) || (await vscode.workspace.openTextDocument(uri)) ←

It may not be a problem specific to Roo, and it might also reproduce in Cline. Sorry, but I haven’t investigated that part.

Detailed Steps to Reproduce

1. Install the Java plugin and open a Spring Boot 3.x project folder in VSCode.
   In my environment, diagnostics are generated for folders like the following, although the exact conditions under which they are generated are unknown:

[{
	"resource": "/H:/sample/",
	"owner": "_generated_diagnostic_collection_name_#5",
	"code": "964",
	"severity": 8,
	"message": "Project 'sample' is missing required source folder: 'build/generated/aotTestSources'",
	"source": "Java",
	"startLineNumber": 1,
	"startColumn": 1,
	"endLineNumber": 1,
	"endColumn": 1
}]

2. Use Roo to edit some files through the tool.

3. Although the file is updated successfully, the tool reports that the operation has failed.

Relevant API Request Output

Additional Context

No response

[dosubot]

こんにちは、@HarukiKosuda2930！私はバグの解決や質問への回答、貢献者になるお手伝いをするためにここにいるボットです。人間のメンテイナーを待ちながら、何かお手伝いできることがあれば教えてください。

The issue you're encountering seems to be related to the getNewDiagnostics function in src/integrations/diagnostics/index.ts. The function attempts to open a URI as a document, which can lead to exceptions if the URI is actually a folder path. This results in a false error report even when the file operation is successful.

To address this, you might need to modify the function to properly handle folder paths. This could involve checking if the URI is a folder before attempting to open it as a document. If the URI is a folder, you could skip the document opening step or handle it differently to avoid exceptions.

Since the exact conditions under which diagnostics are generated for folders are unknown, further investigation might be needed to understand why folder paths are being returned in your environment. This could involve looking into the Java plugin's behavior or any specific project configurations that might be affecting diagnostics generation.

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other}

[hannesrudolph]

I don't understand. Can you please provide a clear repro steps for the problem? Closing for now. Will reopen when provided. Thank you.

[HarukiKosuda2930]

@hannesrudolph

Thank you for your response.

I’ve put together a minimal sample project that reliably reproduces the issue.
Please note that the steps are intentionally crafted to reproduce the error with 100% consistency.
The issue is not about why the Java plugin reports an error. The concern is that Roo's handling of the error reported by the Java plugin is not appropriate.
I was also able to reproduce the issue in Windows Sandbox, so I’ve documented the steps specifically for Windows 10 Pro.
Additionally, I confirmed that the issue does not occur when using the original Cline.
This is likely because the original Cline implementation does not include document caching, making this issue specific to RooCode.

Sample Project:
JavaIssueSample.zip

1. OS: Windows 10 Pro

2. Install jdk-21
   Download from: jdk-21 Windows x64

3. Install Visual Studio Code
   Download from: Visual Studio Code

4. Launch Visual Studio Code

5. Install the Java Extension Pack

6. Install Roo Code

7. Restart Visual Studio Code (as a precaution)

8. Extract JavaIssueSample.zip

9. Open the extracted folder in Visual Studio Code

Wait for the Java plugin to finish analyzing the project.

10. Provide Roo Code with an appropriate instruction Ensure that Auto-approve is turned OFF.
    Example: "Add a list of files to HELP.md".

11. When Roo edits the file and prompts the user to Save/Reject, remove the src/test folder.
    The following error will be displayed:

12. Click "Save" in Roo Code
    The following error will be displayed:

[hannesrudolph]

Thank you @HarukiKosuda2930

[GwylimWilliams]

I am experiencing I think the same error on linux and have verified that cline does not experience the same problem in exactly the same situation; same task, project, VSCode instance and LLM setup (Gemini, VSCode LLM API).

The LLM appears to pass the correct path to the tool (I saw it doing so but cannot find where I looked to see), the file is written but the tool returns the error (above) referring to project root rather than the intended file and complaining that it is a directory.

The problem appears to also afflict the other file editing operations like search and replace and diff application.
I had the LLM work through all of them to try to edit the file. Telling it that the file had actually been written allowed it to proceed but later edits appeared to fail in a similar way but did appear to change the file (though incorrectly in many cases).

This may be related to the VSCode LLM API as I have a very similar setup using gemini directly with no issue. Other models I have tried via VSCode LLM API have the same issue.

Thank you.