Skip to content

Conversation

@jr
Copy link
Collaborator

@jr jr commented Jun 2, 2025

Important

Add logging to Cloud service using createOutputChannelLogger and createDualLogger to log to both console and VSCode output channel.

  • Logging:
    • Add log function to AuthService and CloudService for logging, defaulting to console.log.
    • Use createOutputChannelLogger and createDualLogger in outputChannelLogger.ts to log to both console and VSCode output channel.
  • Initialization:
    • Pass log function to AuthService.createInstance() and CloudService.createInstance() in extension.ts.
  • Testing:
    • Add tests for createOutputChannelLogger and createDualLogger in outputChannelLogger.test.ts.
    • Update CloudService.test.ts to check AuthService.createInstance is called with a logging function.

This description was created by Ellipsis for 8000cc9. You can customize this summary. It will automatically update as commits are pushed.

@jr jr requested review from cte and mrubens as code owners June 2, 2025 23:11
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 2, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 2, 2025
@mrubens
Copy link
Collaborator

mrubens commented Jun 2, 2025

Looks good once tests pass

@jr jr merged commit 927e210 into main Jun 2, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 2, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 2, 2025
@jr jr deleted the jr/cloud-output-logging branch June 2, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants