Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jul 3, 2025

Description

This PR enhances the PR reviewer mode to explicitly prevent duplicate comments by ensuring existing feedback is checked before providing new reviews.

Changes Made

  • Reorganized workflow steps to fetch existing comments BEFORE any code review (moved to Step 4)

  • Added dedicated Step 6 "Verify Existing Comments Against Current Code" with detailed instructions for:

    • Systematically checking each existing comment against current code
    • Marking comments as resolved or still pending
    • Using read_file/codebase_search to verify specific issues
    • Tracking what's been addressed vs. what's still valid
  • Updated Step 8 (Prepare Review Comments) to include critical reminder to cross-reference with Step 6 notes

  • Enhanced Step 9 (Preview) to show which existing comments were verified as resolved

  • Updated best practices to emphasize:

    • Always fetching comments first
    • Creating a list of existing feedback
    • Only providing feedback on NEW or UNRESOLVED issues
  • Enhanced common mistakes to highlight:

    • Not fetching comments before reviewing
    • Failing to systematically check existing feedback
    • Repeating already-addressed feedback

Testing

The changes are to XML instruction files that guide the PR reviewer mode behavior. The workflow now ensures:

  1. Existing comments are fetched first
  2. Each comment is verified against current code
  3. Only new or unresolved issues receive feedback

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic
  • Documentation updated (XML instruction files)
  • No breaking changes

Important

Enhance PR reviewer mode to prevent duplicate comments by reorganizing workflow steps and updating best practices and common mistakes in XML files.

  • Workflow Changes:
    • Reorganize workflow in 1_workflow.xml to fetch existing comments before code review (Step 4).
    • Add Step 6 to verify existing comments against current code, marking them as resolved or pending.
    • Update Step 8 to cross-reference with Step 6 notes before preparing review comments.
    • Enhance Step 9 to preview resolved comments.
  • Best Practices:
    • Emphasize fetching comments first and creating a list of existing feedback.
    • Stress providing feedback only on new or unresolved issues.
  • Common Mistakes:
    • Highlight mistakes like not fetching comments first and repeating addressed feedback.
  • Testing:
    • Ensure workflow fetches comments first, verifies them, and only provides feedback on new or unresolved issues.

This description was created by Ellipsis for 828f4a5. You can customize this summary. It will automatically update as commits are pushed.

- Reorganized workflow to fetch existing comments BEFORE code review (Step 4)
- Added dedicated Step 6 to verify existing comments against current code
- Updated best practices to emphasize checking resolved comments first
- Enhanced common mistakes to highlight duplicate comment prevention
- Added tracking of resolved vs pending comments in the review process
@delve-auditor
Copy link

delve-auditor bot commented Jul 3, 2025

No security or compliance issues detected. Reviewed everything up to 828f4a5.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► 1_workflow.xml
    Reorganized workflow steps for comment fetching and verification
    Added new steps for existing comment verification
► 2_best_practices.xml
    Updated guidelines for comment verification process
► 3_common_mistakes_to_avoid.xml
    Added new mistakes related to comment verification flow

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 3, 2025
@mrubens mrubens merged commit b7d5a96 into main Jul 3, 2025
16 checks passed
@mrubens mrubens deleted the fix/pr-reviewer-duplicate-comments branch July 3, 2025 18:50
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 3, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 3, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer labels Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants