-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: add Kimi, MiniMax, and Qwen model configurations for Bedrock #9905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b931236
fix: add Kimi, MiniMax, and Qwen model configurations for Bedrock
roomote 610a656
fix: add preserveReasoning flag and update Kimi K2 context window
roomote 1e67ca8
fix: update MiniMax M2 context window to 196_608 for Bedrock
roomote 8d696d3
Update packages/types/src/providers/bedrock.ts
mrubens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
moonshot.kimi-k2-thinkingconfiguration still differs from the tested and confirmed working configuration. According to issue #9902 comment #3622616185, the tested configuration usesmaxTokens: 16_000(not 32_000). Additionally, the model is missingsupportsTemperature: trueanddefaultTemperature: 1.0fields, which are present in the moonshot.ts provider configuration and were part of the tested configuration. These fields are important for the model's behavior, as Kimi K2 Thinking uses a default temperature of 1.0.Fix it with Roo Code or mention @roomote and request a fix.