Skip to content

Commit 250e3fe

Browse files
committed
Make get ResourceLocation nullable (Not to get defValue)
1 parent 133becc commit 250e3fe

File tree

7 files changed

+11
-11
lines changed

7 files changed

+11
-11
lines changed

bukkit/version/base/src/main/kotlin/io/github/rothes/esu/bukkit/command/parser/MCRegistryValueParser.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class MCRegistryValueParser<C, T>(
2121
val input = commandInput.readString()
2222

2323
val key = ResourceLocation.tryParse(input.lowercase()) ?: return ArgumentParseResult.failure(unknownKey(input))
24-
val value = accessHandler.get(registry, key) ?: return ArgumentParseResult.failure(unknownKey(input))
24+
val value = accessHandler.getNullable(registry, key) ?: return ArgumentParseResult.failure(unknownKey(input))
2525
return ArgumentParseResult.success(value)
2626
}
2727

bukkit/version/base/src/main/kotlin/io/github/rothes/esu/bukkit/configuration/RegistryValueSerializer.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class RegistryValueSerializer<T: Any>(
3232
return null
3333
}
3434
ResourceKey.create(this.registryKey, key)
35-
return accessHandler.get(registry, key)
35+
return accessHandler.getNullable(registry, key)
3636
}
3737

3838
override fun serialize(item: T, typeSupported: Predicate<Class<*>?>?): Any? {

bukkit/version/base/src/main/kotlin/io/github/rothes/esu/bukkit/util/version/adapter/nms/MCRegistryAccessHandler.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ interface MCRegistryAccessHandler {
1111

1212
fun <T> getRegistryOrThrow(registryAccess: RegistryAccess, registryKey: ResourceKey<out Registry<T>>): Registry<T>
1313

14-
fun <T> get(registry: Registry<T>, resource: ResourceLocation): T?
14+
fun <T> getNullable(registry: Registry<T>, resource: ResourceLocation): T?
1515

1616
fun <T: Any> getResourceKey(registry: Registry<T>, item: T): ResourceKey<T>
1717

bukkit/version/v1_17_1/src/main/kotlin/io/github/rothes/esu/bukkit/util/version/adapter/nms/v1_17_1/MCRegistryAccessHandlerImpl.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ class MCRegistryAccessHandlerImpl: MCRegistryAccessHandler {
1717
return registryAccess.registryOrThrow(registryKey)
1818
}
1919

20-
override fun <T> get(registry: Registry<T>, resource: ResourceLocation): T? {
21-
return registry.get(resource)
20+
override fun <T> getNullable(registry: Registry<T>, resource: ResourceLocation): T? {
21+
return registry.getOptional(resource).orElse(null)
2222
}
2323

2424
override fun <T: Any> getResourceKey(registry: Registry<T>, item: T): ResourceKey<T> {

bukkit/version/v1_18_2/src/main/kotlin/io/github/rothes/esu/bukkit/util/version/adapter/nms/v1_18_2/MCRegistryAccessHandlerImpl.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ class MCRegistryAccessHandlerImpl: MCRegistryAccessHandler {
1717
return registryAccess.registryOrThrow(registryKey)
1818
}
1919

20-
override fun <T> get(registry: Registry<T>, resource: ResourceLocation): T? {
21-
return registry.get(resource)
20+
override fun <T> getNullable(registry: Registry<T>, resource: ResourceLocation): T? {
21+
return registry.getOptional(resource).orElse(null)
2222
}
2323

2424
override fun <T: Any> getResourceKey(registry: Registry<T>, item: T): ResourceKey<T> {

bukkit/version/v1_19_3/src/main/kotlin/io/github/rothes/esu/bukkit/util/version/adapter/nms/v1_19_3/MCRegistryAccessHandlerImpl.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ class MCRegistryAccessHandlerImpl: MCRegistryAccessHandler {
1919

2020
// Change: Registry is now interface
2121

22-
override fun <T> get(registry: Registry<T>, resource: ResourceLocation): T? {
23-
return registry.get(resource)
22+
override fun <T> getNullable(registry: Registry<T>, resource: ResourceLocation): T? {
23+
return registry.getOptional(resource).orElse(null)
2424
}
2525

2626
override fun <T: Any> getResourceKey(registry: Registry<T>, item: T): ResourceKey<T> {

bukkit/version/v1_21_3/src/main/kotlin/io/github/rothes/esu/bukkit/util/version/adapter/nms/v1_21_3/MCRegistryAccessHandlerImpl.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ class MCRegistryAccessHandlerImpl: MCRegistryAccessHandler {
1717
return registryAccess.lookupOrThrow(registryKey) // Change: method name
1818
}
1919

20-
override fun <T> get(registry: Registry<T>, resource: ResourceLocation): T? {
21-
return registry.getValue(resource)
20+
override fun <T> getNullable(registry: Registry<T>, resource: ResourceLocation): T? {
21+
return registry.getOptional(resource).orElse(null)
2222
}
2323

2424
override fun <T: Any> getResourceKey(registry: Registry<T>, item: T): ResourceKey<T> {

0 commit comments

Comments
 (0)