Cleanup RegistryValueSerializer

- Optimize constructor params
- Not to create ResourceKey

Author: Rothes

bukkit/version/base/src/main/kotlin/io/github/rothes/esu/bukkit/configuration/RegistryValueSerializer.kt

@@ -4,34 +4,26 @@ import io.github.rothes.esu.bukkit.util.version.adapter.nms.MCRegistryAccessHand
 import io.github.rothes.esu.lib.configurate.serialize.ScalarSerializer
 import io.leangen.geantyref.TypeToken
 import net.minecraft.core.Registry
-import net.minecraft.core.RegistryAccess
 import net.minecraft.resources.ResourceKey
 import net.minecraft.resources.ResourceLocation
 import java.lang.reflect.Type
 import java.util.function.Predicate
 
 class RegistryValueSerializer<T: Any>(
     val accessHandler: MCRegistryAccessHandler,
-    val registryKey: ResourceKey<out Registry<T>>,
-    clazz: TypeToken<T>,
-    registryAccess: RegistryAccess = accessHandler.getServerRegistryAccess(),
-): ScalarSerializer<T>(clazz) {
+    registryKey: ResourceKey<out Registry<T>>,
+    type: TypeToken<T>,
+): ScalarSerializer<T>(type) {
 
-    constructor(
-        accessHandler: MCRegistryAccessHandler,
-        registryKey: ResourceKey<out Registry<T>>,
-        clazz: Class<T>,
-        registryAccess: RegistryAccess = accessHandler.getServerRegistryAccess(),
-    ): this(accessHandler, registryKey, TypeToken.get(clazz), registryAccess)
+    constructor(accessHandler: MCRegistryAccessHandler, registryKey: ResourceKey<out Registry<T>>, clazz: Class<T>): this(accessHandler, registryKey, TypeToken.get(clazz))
 
-    val registry = accessHandler.getRegistryOrThrow(registryAccess, registryKey)
+    val registry = accessHandler.getRegistryOrThrow(accessHandler.getServerRegistryAccess(), registryKey)
 
     override fun deserialize(type: Type?, obj: Any?): T? {
         val key = ResourceLocation.tryParse(obj.toString().lowercase()) ?: let {
             IllegalArgumentException("Failed to parse $obj to ResourceLocation, ignored.").printStackTrace()
             return null
         }
-        ResourceKey.create(this.registryKey, key)
         return accessHandler.getNullable(registry, key)
     }