Optimize loop over IntList

Author: Rothes

bukkit/src/main/kotlin/io/github/rothes/esu/bukkit/module/networkthrottle/entityculling/UserCullData.kt

@@ -7,6 +7,7 @@ import io.github.rothes.esu.bukkit.util.scheduler.Scheduler
 import io.github.rothes.esu.bukkit.util.version.Versioned
 import io.github.rothes.esu.bukkit.util.version.adapter.PlayerAdapter.Companion.connected
 import io.github.rothes.esu.bukkit.util.version.adapter.TickThreadAdapter.Companion.checkTickThread
+import io.github.rothes.esu.core.util.extension.forEachInt
 import io.github.rothes.esu.core.util.extension.math.square
 import it.unimi.dsi.fastutil.Hash
 import it.unimi.dsi.fastutil.ints.Int2ReferenceOpenHashMap
@@ -59,10 +60,9 @@ class UserCullData(
 
     fun onEntityRemove(entities: IntArrayList) {
         if (entities.isEmpty) return
-        val iterator = entities.listIterator()
         synchronized(hiddenEntities) {
-            while (iterator.hasNext()) {
-                hiddenEntities.remove(iterator.nextInt())
+            entities.forEachInt { i ->
+                hiddenEntities.remove(i)
             }
         }
     }

bukkit/version/v1_18/src/main/kotlin/io/github/rothes/esu/bukkit/module/networkthrottle/chunkdatathrottle/v1_18/ChunkDataThrottleHandlerImpl.kt

@@ -43,6 +43,7 @@ import io.github.rothes.esu.bukkit.util.version.adapter.nms.ChunkSender
 import io.github.rothes.esu.bukkit.util.version.adapter.nms.LevelHandler
 import io.github.rothes.esu.bukkit.util.version.adapter.nms.PalettedContainerReader
 import io.github.rothes.esu.core.util.UnsafeUtils.usObjAccessor
+import io.github.rothes.esu.core.util.extension.forEachInt
 import it.unimi.dsi.fastutil.ints.IntArrayList
 import it.unimi.dsi.fastutil.longs.Long2ObjectMap
 import it.unimi.dsi.fastutil.longs.Long2ObjectOpenHashMap
@@ -450,9 +451,7 @@ class ChunkDataThrottleHandlerImpl: ChunkDataThrottleHandler,
                             if (z != 0 ) pending.add(id - 0x010)
                             if (z != 15) pending.add(id + 0x010)
                         }
-                        val iterator = pending.intIterator()
-                        while (iterator.hasNext()) {
-                            val i = iterator.nextInt()
+                        pending.forEachInt { i ->
                             if (bvArr[i] and INVISIBLE == INVISIBLE) {
                                 invisible[i] = BV_INVISIBLE
                             }
@@ -484,9 +483,7 @@ class ChunkDataThrottleHandlerImpl: ChunkDataThrottleHandler,
                             checkBlock(id + 0x100, Y_MINUS)
                             pending.add(id)
                         }
-                        val iterator = pending.intIterator()
-                        while (iterator.hasNext()) {
-                            val i = iterator.nextInt()
+                        pending.forEachInt { i ->
                             if (bvArr[i] and INVISIBLE == INVISIBLE) {
                                 invisible[i] = BV_INVISIBLE
                             }

core/src/main/kotlin/io/github/rothes/esu/core/util/extension/Collections.kt

@@ -1,5 +1,7 @@
 package io.github.rothes.esu.core.util.extension
 
+import it.unimi.dsi.fastutil.ints.IntList
+
 fun <T> listOfJvm(element: T): List<T> {
     return ArrayList<T>(1).apply {
         add(element)
@@ -19,4 +21,9 @@ inline fun <T, R> Collection<T>.mapJvm(transform: (T) -> R): List<R> {
     for (item in this)
         destination.add(transform(item))
     return destination
+}
+
+inline fun IntList.forEachInt(action: (Int) -> Unit) {
+    for (i in 0 until this.size)
+        action(getInt(i))
 }