chore: move QuickSight embedding behind a workspace package#1693
Conversation
There was a problem hiding this comment.
Won't 100% know that this works until it's out on QA.
The quicksight dashboard setup on my dev box is not valid. It 500's with or without the changes in this PR.
There was a problem hiding this comment.
npm run deploy:qa2 or npm run deploy:qa
There was a problem hiding this comment.
I just pushed it out to qa1, looks like it works as before.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
RoundingWell Care Ops Frontend
 |
||||||||||||||||||||||||||||
| Project |
RoundingWell Care Ops Frontend
|
| Branch Review |
quicksight-pkg
|
| Run status |
|
| Run duration | 02m 08s |
| Commit |
|
| Committer | nmajor25 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
236
|
| View all changes introduced in this branch ↗︎ | |
Coverage Report for CI Build 7895Coverage remained the same at 99.975%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Not sure what the solution is. But when I run npm install locally on my mac machine, these are removed from the package-lock.json:
"node_modules/@emnapi/core": {
"version": "1.10.0",
"resolved": "https://registry.npmjs.org/@emnapi/core/-/core-1.10.0.tgz",
"integrity": "sha512-yq6OkJ4p82CAfPl0u9mQebQHKPJkY7WrIuk205cTYnYe+k2Z8YBh11FrbRG/H6ihirqcacOgl2BIO8oyMQLeXw==",
"dev": true,
"license": "MIT",
"optional": true,
"dependencies": {
"@emnapi/wasi-threads": "1.2.1",
"tslib": "^2.4.0"
}
},
"node_modules/@emnapi/runtime": {
"version": "1.10.0",
"resolved": "https://registry.npmjs.org/@emnapi/runtime/-/runtime-1.10.0.tgz",
"integrity": "sha512-ewvYlk86xUoGI0zQRNq/mC+16R1QeDlKQy21Ki3oSYXNgLb45GV1P6A0M+/s6nyCuNDqe5VpaY84BzXGwVbwFA==",
"dev": true,
"license": "MIT",
"optional": true,
"dependencies": {
"tslib": "^2.4.0"
}
},There was a problem hiding this comment.
Which then causes the circleci npm ci install to fail. Because that is on a linux machine and needs those packages.
There was a problem hiding this comment.
So I had to manually add those back to the package-lock.json file to get things working on ci.
There was a problem hiding this comment.
you're sure you're on node 24.15?
There was a problem hiding this comment.
I was using v24.12, that would cause this issue?
There was a problem hiding this comment.
After switching to v24.15, it doesn't seem to remove those on npm install. So think we're good.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/care-ops-quicksight/index.js">
<violation number="1" location="packages/care-ops-quicksight/index.js:7">
P1: Reset the cached embedding promise when initialization fails; otherwise one transient `createEmbeddingContext()` error permanently breaks all later embeds in this session.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
nmajor25
force-pushed
the
quicksight-pkg
branch
3 times, most recently
from
2ec3da6 to
a636d7b
Compare
|
|
||
| import { View } from 'marionette'; | ||
|
|
||
| import { embedDashboard } from '@roundingwell/care-ops-quicksight'; |
There was a problem hiding this comment.
yeah I dunno.. I think this still might be better in the beforeStart because that was running onFail on a failure.. now there's no real failure route for the amazon sdk
There was a problem hiding this comment.
Makes sense, I updated this to put it back in the beforeStart 👍
There was a problem hiding this comment.
you're sure you're on node 24.15?
There was a problem hiding this comment.
npm run deploy:qa2 or npm run deploy:qa
nmajor25
changed the title
3 participants
Closes FE-131
Summary by cubic
Moved AWS QuickSight embedding into a new workspace package
@roundingwell/care-ops-quicksightto centralize the SDK and simplify the dashboards app. Addresses FE-131 by wrapping embedding and fixing a race with a cached embedding context promise.Refactors
getEmbeddingContext()with a memoized promise that resets on error;embedDashboard()uses it.dashboard_app;IframeViewnow callsembedDashboarddirectly.Dependencies
amazon-quicksight-embedding-sdkunder@roundingwell/care-ops-quicksight; removed from root.Written for commit 9b4b9fa. Summary will update on new commits. Review in cubic