Backported Decision tree off-by-one fix

DrDub · DrDub · commit f369730132e6 · 2022-12-06T23:18:47.000-08:00
Pull Request #210 included a bug fix for a off-by-one bug found thanks to the visualzation (see #210 (comment) for details).
diff --git a/src/Graph/Trees/DecisionTree.php b/src/Graph/Trees/DecisionTree.php
@@ -226,7 +226,7 @@ public function search(array $sample) : ?Outcome
                         $current = $current->right();
                     }
                 } else {
-                    if ($sample[$current->column()] < $value) {
+                    if ($sample[$current->column()] <= $value) {
                         $current = $current->left();
                     } else {
                         $current = $current->right();

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ public function search(array $sample) : ?Outcome`
`226`	`226`	`$current = $current->right();`
`227`	`227`	`}`
`228`	`228`	`} else {`
`229`		`- if ($sample[$current->column()] < $value) {`
	`229`	`+ if ($sample[$current->column()] <= $value) {`
`230`	`230`	`$current = $current->left();`
`231`	`231`	`} else {`
`232`	`232`	`$current = $current->right();`