Skip to content

Hide empty profile event sections after filtering#1842

Merged
marcoroth merged 1 commit into
rubyevents:mainfrom
minhluuquang:fix-1834-hide-empty-filtered-event-sections
Jun 29, 2026
Merged

Hide empty profile event sections after filtering#1842
marcoroth merged 1 commit into
rubyevents:mainfrom
minhluuquang:fix-1834-hide-empty-filtered-event-sections

Conversation

@minhluuquang

Copy link
Copy Markdown
Contributor

Description

Moves the events-filter group target from the profile event grids to the Future/Past section wrappers. When a kind filter hides every card in one section, the Stimulus controller now hides that section heading with the grid instead of leaving an empty "Future Events" or "Past Events" heading visible.

Screenshots

Not included; this is a small markup target change for the existing filter behavior.

Testing Steps

  • bin/vite build --clear --mode=test
  • bin/rails test test/controllers/profiles/events_controller_test.rb
  • bundle exec erb_lint app/views/profiles/_events.html.erb
  • git diff --check

References

@marcoroth marcoroth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @minhluuquang! 🙏🏼

@marcoroth marcoroth merged commit aa0e4bc into rubyevents:main Jun 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't show "Future Events" if there are no future events of this kind

2 participants