add normalization step of embedded undifferentiated/ground-fact-differentiated objectification #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mthom
commented
Sep 11, 2020
mthom
commented
- Add this embobj step just before and in preparation for unnest step.
- Use embedded differentiated objectification for ground facts.
- Use embedded undifferentiated objectification for everything else.
- Modify parser for - oidless atoms that have - "#"-prefixed predicates to emit subtrees describing top-level atoms and (with a newly introduced token type) embedded atoms.
- Add a walker generating fresh OIDs and inserting them for those tokens.
- Upgrade from ANTLR 3.4 to ANTLR 3.5.2 to overcome backtracking bug.
… XML-style comment blocks
…ee grammar to process embedded atoms
…jectifications on what it heuristically identifies as ground facts
mthom
force-pushed
the
ground_fact_differentiated_embedded_objectification
branch
8 times, most recently
from
2218d65 to
1af695f
Compare
to distinguish top-level atoms from embedded atoms.
PSOATransRun/test-basic/embobj/ex_0/embobj_ex_0-KB.psoa, with (in comment blocks) example query/solution pairs against the KB
mthom
force-pushed
the
ground_fact_differentiated_embedded_objectification
branch
from
1af695f to
2903cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.