Skip to content

Conversation

@thingineeer
Copy link
Collaborator

🌱 작업한 내용

  • 공유기능 추가
  • 팔로우, 팔로잉 버튼 추가 (기능 구현 x)
  • 현재위치 시작, 지도에서 선택 버튼 추가 (기능 구현x)
  • 자잘한 오타 수정
  • 카카오 SDK 가 추가 됐으니 작동이 안된다면 pod install 해야합니다.

🌱 PR Point

공유기능 AppDelegate 수정 해야합니다.
DeepLink 수정도 해야합니다.
🔥 merge 하지 마세요!! 미완성이기 때문에 공유하기 위해 만든 PR 입니다. 🔥

자세한 설명은 완벽하게 구현 후 자세하게 적겠습니다.

  • PR Point 1

📸 스크린샷

구현 내용 스크린샷
ex. 로그인 화면 파일첨부바람

📮 관련 이슈

  • Resolved: #이슈번호

@thingineeer thingineeer added Add Feat 이외의 부수적인 코드 추가, 새로운 View 생성, 파일 추가 Feat 새로운 기능 구현 명진😼 labels Aug 29, 2023
@gitguardian
Copy link

gitguardian bot commented Sep 6, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Google API Key 917876b Runnect-iOS/Runnect-iOS/GoogleService-Info.plist View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@thingineeer thingineeer closed this Sep 7, 2023
@thingineeer thingineeer deleted the Feat]-#178---CourseDetailVC-UI-수정 branch September 7, 2023 07:19
@thingineeer thingineeer self-assigned this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Add Feat 이외의 부수적인 코드 추가, 새로운 View 생성, 파일 추가 Feat 새로운 기능 구현 명진😼

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant