Skip to content

Conversation

@thingineeer
Copy link
Collaborator

@thingineeer thingineeer commented Jan 7, 2024

🌱 작업한 내용

  • 빌드 버전을 변경 하였습니다.
  • 공유 배너 추가 하였습니다.
  • 코스 검색 관련 Dto를 변경 하였습니다. (재사용 하기 위함)

🌱 PR Point

  • 버전 바꿨습니다.

📮 관련 이슈

@thingineeer thingineeer added Setting 프로젝트 세팅, 라이브러리 설치 명진😼 labels Jan 7, 2024
@thingineeer thingineeer requested a review from 513sojin January 7, 2024 03:35
@thingineeer thingineeer self-assigned this Jan 7, 2024
Copy link
Collaborator Author

@thingineeer thingineeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료

@thingineeer thingineeer changed the title #242 - 1.0.8 버전 수정 및 배너 수정 [Setting] #242 - 1.0.8 버전 수정 및 배너 수정 Jan 8, 2024
Copy link
Collaborator

@513sojin 513sojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세심 앤드 꼼꼼 앤드 알잘딱깔센으로 사소한 변경 사항 수정해주셔서 감사하옵니다. 수고하셨어요 !!

Comment on lines +14 to +15
let publicCourse: Int?
let scarpTF: Bool?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옵셔널 값 줘서 dto 또 안만든 명진 칭찬해 ..

Comment on lines +131 to +144
// 터치 이벤트 임시 제거
// if indexPath.item == 0 {
// let tapGesture = UITapGestureRecognizer(target: self, action: #selector(firstCellTapped(_:)))
// imageView.addGestureRecognizer(tapGesture)
// }
return cell
}
// 첫 번째 셀 클릭 이벤트 핸들러
@objc func firstCellTapped(_ gesture: UITapGestureRecognizer) {
// Safari 링크로 연결
if let url = URL(string: "https://docs.google.com/forms/d/1cpgZHNNi1kIvi2ZCwCIcMJcI1PkHBz9a5vWJb7FfIbg/edit") {
UIApplication.shared.open(url)
}
}
// @objc func firstCellTapped(_ gesture: UITapGestureRecognizer) {
// // Safari 링크로 연결
// if let url = URL(string: "https://docs.google.com/forms/d/1cpgZHNNi1kIvi2ZCwCIcMJcI1PkHBz9a5vWJb7FfIbg/edit") {
// UIApplication.shared.open(url)
// }
// }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배너 터치 이벤트 뺀거 확인했습니다 ~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 감사합니다 ~

@thingineeer thingineeer merged commit 4c46cfa into Runnect:develop Jan 11, 2024
@thingineeer thingineeer deleted the #242---1.0.8-버전-수정-및-배너-수정 branch January 11, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Setting 프로젝트 세팅, 라이브러리 설치 명진😼

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Setting] #242 - 1.0.8 버전 수정 및 배너 수정

2 participants