[Setting] #253 - Remote Config 세팅 작업을 완료 하였습니다. #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thingineeer
changed the title
513sojin
reviewed
Feb 7, 2024
Comment on lines
+171
to
+177
| private func setObserver() { | ||
| NotificationCenter.default.publisher(for: UIApplication.willEnterForegroundNotification) | ||
| .sink { [weak self] _ in | ||
| self?.setRemoteConfig() | ||
| } | ||
| .store(in: cancelBag) | ||
| } |
Collaborator
There was a problem hiding this comment.
앗..!!!!!!!!!!!!! 이걸 못떠올려서 splash에서 처리가 힘들었었는데 .. 천재만재 만만재 이명진 ㅠㅠ
513sojin
approved these changes
Feb 7, 2024
Collaborator
513sojin
left a comment
513sojin
left a comment
There was a problem hiding this comment.
willEnterForegroundNotification 배워갑니다 ,, 고생하셨어요 !!
Comment on lines
+124
to
+127
| let splitCurrentVersion = currentVersion.split(separator: ".").map { $0 } | ||
| let splitStoreVersion = storeVersion.split(separator: ".").map { $0 } | ||
|
|
||
| if splitCurrentVersion[0] < splitStoreVersion[0] { |
Collaborator
There was a problem hiding this comment.
버전 앞 자리만 비교해서 업데이트 팝업 띄우는 부분 확인했습니다 ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
메이저 버전에 한정 지어서 설정하였습니다.willEnterForegroundNotification부분 처리를 해주었습니다.📸 스크린샷
📮 관련 이슈