Skip to content

[Fix] #31 - UICollectionViewCell 간 간격 수정 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

[Fix] #31 - UICollectionViewCell 간 간격 수정 #36

merged 1 commit into from
Jan 5, 2023

Conversation

@dlwogus0128
Copy link
Contributor

@dlwogus0128 dlwogus0128 commented Jan 4, 2023 •
edited
Loading

🌱 작업한 내용

  • UICollectionViewCell 간 간격 수정

🌱 PR Point

  • 기기의 종류를 바꾸었을 때 콜렉션 뷰의 셀 간격이 깨지는 것을 해결했습니다.
  • 셀의 너비 값을 활용해, 비율을 계산하여 높이를 구하는 방법을 깨달았습니다.

📸 스크린샷

구현 내용 스크린샷
iPhone se일 때 화면

📮 관련 이슈

@dlwogus0128 dlwogus0128 self-assigned this Jan 4, 2023
@dlwogus0128 dlwogus0128 added bug Something isn't working 재현🐶 labels Jan 4, 2023
lsj8706
lsj8706 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿~!

@dlwogus0128 dlwogus0128 merged commit cd1f9e3 into Runnect:develop Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsj8706 lsj8706 lsj8706 approved these changes

@lee-yeonwoo lee-yeonwoo Awaiting requested review from lee-yeonwoo

Assignees

@dlwogus0128 dlwogus0128

Labels

bug Something isn't working 재현🐶

Projects

Runnect-iOS
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Fix] UICollectionView 오류 해결

2 participants

@dlwogus0128 @lsj8706