[Feat] #78 - 활동 기록 API 연결 #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
스택뷰 안의 요소들 너비와 이를 감싸는 스택뷰 너비를 이중으로 설정해서 생긴 문제.. 해결..
lsj8706
approved these changes
Jan 11, 2023
Collaborator
lsj8706
left a comment
lsj8706
left a comment
There was a problem hiding this comment.
수고하셨습니다~!! 리뷰 반영해서 머지 해주세요!!
|
|
||
| // MARK: - Record | ||
|
|
||
| struct Record: Codable { |
Collaborator
There was a problem hiding this comment.
이 친구 이름을 ActivityRecord 하는게 좋아보여요!
Comment on lines
98
to
107
| // 날짜 바꾸기 | ||
| let activityRecordDate = model.createdAt.prefix(10) | ||
| let dateFormatter = DateFormatter() | ||
| dateFormatter.dateFormat = "yyyy-MM-dd" | ||
| let convertDate = dateFormatter.date(from: String(activityRecordDate)) | ||
| guard let convertDate = convertDate else { return } | ||
|
|
||
| let resultDateFormatter = DateFormatter() | ||
| resultDateFormatter.dateFormat = "yyyy.MM.dd" | ||
| let resultDate = resultDateFormatter.string(from: convertDate) |
Collaborator
There was a problem hiding this comment.
이 친구들은 따로 함수로 만드는게 좋아보여요!
RNTimeFormatter.swift 에 이런 시간 포매팅 관련 함수들을 모으고 있어서 거기에 만들어도 좋을 거 같아요!! 함수 앞에 static을 붙이면 RNTimeFormatter.만든함수() 이렇게 인스턴스를 만들지 않고 사용할 수 있어요!!
Comment on lines
110
to
114
| let activityRecordRunningTime = model.time.suffix(7) | ||
|
|
||
| // 평균 페이스 바꾸기 | ||
| let activityRecordAveragePace = model.pace | ||
| let array = activityRecordAveragePace.split(separator: ":").map { String($0) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
생략
📮 관련 이슈