Skip to content

Conversation

@hhellyer
Copy link
Member

@hhellyer hhellyer commented Aug 4, 2017

Use the "connected" message to re-send static data when the client confirms it's connected to avoid timing issues.
This fixes an issue with the environment page, profiling enablement and title that caused them to sometimes fail to be set.
This also resolves an issue with being unable to see generated node-report files or heap dumps.

Copy link
Member

@tobespc tobespc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Aug 4, 2017

Codecov Report

Merging #102 into master will decrease coverage by 0.61%.
The diff coverage is 30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   60.35%   59.74%   -0.62%     
==========================================
  Files           2        2              
  Lines         227      231       +4     
==========================================
+ Hits          137      138       +1     
- Misses         90       93       +3
Impacted Files Coverage Δ
lib/appmetrics-dash.js 59.56% <30%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e5d42c...16431a1. Read the comment docs.

@tobespc tobespc merged commit 14a97f4 into RuntimeTools:master Aug 4, 2017
@tobespc tobespc added this to the 3.3.3 milestone Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants