gccrs: Fix ICE on enum in tuple struct pattern #4241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowr
force-pushed
the
fix/enum-in-tuple-struct-pat
branch
from
a3c2e07 to
36d75ba
Compare
|
This also fixes the ICE for #3926, maybe you can add a test for it as well, thanks! |
When we typecheck a tuple struct pattern and the type of its path is an enum, it may refer to the enum itself and not a variant. Emit an E0532 error on such cases. Fixes Rust-GCC#3917 Fixes Rust-GCC#3918 Fixes Rust-GCC#3926 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (TypeCheckPattern::visit): Emit an error when the path refers to an enum itself rather than its variant. gcc/testsuite/ChangeLog: * rust/compile/match-tuplestructpattern-non-variant.rs: New test. Signed-off-by: Ryo Yoshida <low.ryoshida@gmail.com>
lowr
force-pushed
the
fix/enum-in-tuple-struct-pat
branch
from
36d75ba to
a346043
Compare
|
@Polygonalr Thanks for the heads up! I've updated the commit message and the PR description to include #3926. I think the new test already covers the case, but let me know if I should tweak something. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an ICE during typeckecking tuple struct patterns. When the type of a tuple struct pattern's path is resolved to an enum, the path is expected to refer to an enum variant in a correct Rust program. However, it may refer to the enum itself, in which case we should emit an error.
Note that while #3917 reported that the given code had run into an ICE during AST lowering, it currently causes an ICE in typecheck at the same location as #3918. This PR therefore resolves both issues.
Fixes #3917
Fixes #3918
Fixes #3926