"Unintern" DataInstForm (inlining its fields back into DataInstDef).
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LegNeato
approved these changes
Nov 6, 2024
Collaborator
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Don't understand the code yet, but the changes look pretty mechanical and clean stuff up nicely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively undoes:
DataInstForm, thekindandoutput_typefields ofDataInstDef. EmbarkStudios/spirt#28Some quick unscientific testing reveals no significant perf impact (i.e. the difference is lost in the noise).
The motivation for undoing this interning is the prospect of combining
DataInstDefintoNodeDef(as mentioned in #7), and for unrelated pragmatic reasons,NodeDefcan't have its outputs interned (though long-term maybe we could intern thekindfield, if really necessary, assuming we first take "child regions" out of it).The one thing I realized too late there's no pre-existing consensus for, is the
output_type, which used to be betweenkindandinputs(matchingDataInstFormDef, in fact), whileNodeDef'soutputsis the last field.The only argument to have outputs first is the
let (out0, out1) = foo(in0, in1);style syntax (though pretty-printed SPIR-T omits thelet), but I'm not sure that's worth flipping the order over.