Use a direct formula to calculate log(2^x)
#475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Feb 13, 2025
|
Sidebar: @fjarri any thoughts on including some prime counting functionality in Edit: sorry if I've asked this before, I know you said it doesn't currently exist but I forget what you said about potentially including it |
|
I think it will be appropriate there. If you have some specific formulas/papers in mind, could you make an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the current approximate
logf()which we don't really need for this specific form of the argument.Note: I am not sure why we calculate
log(2^floor(bit_size / nprimes))while we could just as well calculatelog(2^(bit_size/nprimes)), but I left that part intact.