BoxedUint: improve efficiency of square
#382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a more efficient squaring algorithm with fewer iterations, with an implementation shared with `Uint`. Proptested against `num-bigint`.
tarcieri
added a commit
that referenced
this pull request
Dec 4, 2023
This reverts commit cd9cdce. Benchmarks reveal this caused a performance regression to modpow. Reverting it yields the following improvement: Montgomery arithmetic/modpow, BoxedUint^BoxedUint time: [76.362 µs 76.381 µs 76.403 µs] change: [-72.846% -72.795% -72.747%] (p = 0.00 < 0.05) Performance has improved.
tarcieri
added a commit
that referenced
this pull request
Dec 4, 2023
This reverts commit cd9cdce. Benchmarks reveal this caused a performance regression to modpow. Reverting it yields the following improvement: Montgomery arithmetic/modpow, BoxedUint^BoxedUint time: [76.362 µs 76.381 µs 76.403 µs] change: [-72.846% -72.795% -72.747%] (p = 0.00 < 0.05) Performance has improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a more efficient squaring algorithm with fewer iterations, with an implementation shared with
Uint.Proptested against
num-bigint.