der: have PemReader decode to Cow::Owned
#2094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an associated `CAN_READ_SLICE` boolean flag to the `Reader` trait. When false, `Cow` decodes the owned type rather than the borrow one. This makes it possible to use `Cow` with `PemReader`, where it will automatically decode the owned type.
tarcieri
commented
Nov 7, 2025
|
|
||
| #[cfg(feature = "alloc")] | ||
| impl<'a, T> DecodeValue<'a> for Cow<'a, T> | ||
| impl<'a, T, E> DecodeValue<'a> for Cow<'a, T> |
Member
Author
There was a problem hiding this comment.
This still somewhat annoyingly ties the lifetime of the Cow to the lifetime of the Reader, which for PemReader is still the lifetime of the input buffer.
Member
Author
There was a problem hiding this comment.
Aha, that's easily fixable by making it impl Reader<'static> instead
dishmaker
reviewed
Nov 7, 2025
| T: ToOwned + ?Sized, | ||
| &'a T: DecodeValue<'a>, | ||
| &'a T: DecodeValue<'a, Error = E>, | ||
| T::Owned: for<'b> DecodeValue<'b, Error = E>, |
Member
Author
There was a problem hiding this comment.
It's really necessary here to show that the output lifetime is independent of the input lifetimes, which should let Reader<'static> work when decoding Cow<'static, T>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an associated
CAN_READ_SLICEboolean flag to theReadertrait.When false,
Cowdecodes the owned type rather than the borrow one.This makes it possible to use
CowwithPemReader, where it will automatically decode the owned type.