refactor(any_node_ref): revamp for leptos 0.7 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 22, 2024 12:53
…dling - Introduced the trait to enable conversion of typed s to - Facilitates generic operations on various node references across HTML, SVG, and Math node types - Added comprehensive tests to ensure the functionality and reliability of the new trait - Updated to reflect version bump to 0.0.4
- Implement generic NodeRefContainer<E> to handle node references consistently across elements - Add type-safe conversions between specific NodeRef<E> and type-erased AnyNodeRef - Improve attribute handling for conditional rendering with AnyNodeRefAttr - Fix issue with node refs being spread across multiple elements in conditionals
4 tasks
|
#8 is contained in this PR with more. |
geoffreygarrett
changed the title
|
Closing this draft PR in favor of three separate feature PRs for better review and maintainability:
These PRs contain the same changes but split into logical, independent features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified node reference handling for Leptos 0.7 that supports type-safe conditional/dynamic rendering:
NodeRefContainer<E>implementationNodeRef<E>and type-erasedAnyNodeRefAnyNodeRefAttrPart of a larger update across
RustForWeb/radixcomponents - additional PRs will follow that depend on these changes.