Skip to content

Fixes #169 - Dependency on workspace crate are handled wrong#175

Merged
tarcieri merged 7 commits intorustsec:masterfrom
kegesch:master
Jan 6, 2020
Merged

Fixes #169 - Dependency on workspace crate are handled wrong#175
tarcieri merged 7 commits intorustsec:masterfrom
kegesch:master

Conversation

@kegesch
Copy link
Copy Markdown
Contributor

@kegesch kegesch commented Dec 19, 2019

This merge should wait for RustSec/rustsec-crate#128

@kegesch
Copy link
Copy Markdown
Contributor Author

kegesch commented Dec 20, 2019

When are planning to make a new release for rustsec-crate? I have to wait for it right?

@tarcieri
Copy link
Copy Markdown
Member

@kegesch feel free to switch to a git dependency / add a patch directive. I'll cut a release before another release of cargo-audit.

os = "linux" # Ignore advisories for operating systems other than this one

[packages]
source = "All" # "All", "Public" or "Local"
Copy link
Copy Markdown
Member

@tarcieri tarcieri Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer lowercase names for these. I guess that needs a #[serde(rename = "...")] in the rustsec crate?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge this PR. Would appreciate followups for the above, otherwise I can take care of them before I cut final releases.

@tarcieri tarcieri merged commit 9d99a90 into rustsec:master Jan 6, 2020
@tarcieri tarcieri mentioned this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants