Adds --json flag to output JSON to STDOUT#41
Merged
tarcieri merged 4 commits intorustsec:masterfrom Oct 25, 2018
Merged
Conversation
colindean
commented
Oct 15, 2018
| lazy_static = "1" | ||
| platforms = "0.1" | ||
| rustsec = "0.9" | ||
| rustsec = "0.9.3" |
Contributor
Author
There was a problem hiding this comment.
@tarcieri I realized just moments after I changed this to 0.9.3 that maybe it should be less specific. What should it be?
…Or you could merge it and change it to be less specific in another commit…
Member
|
@colindean as it were I just released |
Contributor
Author
|
…Gonna rebase. |
Flag is added and it works as a proof-of-concept, but it's difficult to get the JSON out of the output because _everything_ is output to STDOUT.
All other output text goes to STDERR. I'm not particularly happy with the implementation of deciding which io fd to use. I tried to put it into a variable just above it but got the frustrating and unhelpful error "cannot move out of captured outer variable…" so I did it like this until someone can clean it up.
colindean
force-pushed
the
colindean/json-output
branch
from
d164572 to
1d24287
Compare
Contributor
Author
|
It looks like this is good to go! |
Member
|
Great, thanks! And sorry it took so long |
Contributor
Author
|
🎉 |
Merged
tarcieri
added a commit
that referenced
this pull request
May 7, 2021
…vulns-pkgs Derive Serialize for Packages, Vulnerabilities, and Vulnerability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40