Fixes for Group and ContextActivities #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The check to make sure the properties were set was not happening soon enough so that the set methods through the _listSetter were trying to push to arrays that were not defined yet * Improve tests for fromJSON instantiation in ContextActivities
Member
Author
|
@bscSCORM for direct review, if you want me to find another reviewer I'm happy to. |
bscSCORM
added a commit
that referenced
this pull request
Jul 23, 2014
Fixes for Group and ContextActivities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All unit tests (such as they are) pass and are quiet now.