Skip to content

Commit c4e10ea

Browse files
uber5001tbosch
authored andcommitted
chore(benchpress): add browserify bundling
Use browserify to bundle benchpress and its dependencies.
1 parent f1cf529 commit c4e10ea

File tree

11 files changed

+1413
-14
lines changed

11 files changed

+1413
-14
lines changed

gulpfile.js

Lines changed: 38 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,30 @@ var CONFIG = {
124124
},
125125
dart: 'dist/dart',
126126
docs: 'dist/docs',
127-
docs_angular_io: 'dist/angular.io'
127+
docs_angular_io: 'dist/angular.io',
128+
benchpress_bundle: 'dist/build/benchpress_bundle/'
128129
}
129130
};
130131

132+
var BENCHPRESS_BUNDLE_CONFIG = {
133+
entries: ['./dist/js/cjs/benchpress/index.js'],
134+
packageJson: './dist/js/cjs/benchpress/package.json',
135+
includes: [
136+
'angular2',
137+
'traceur',
138+
'reflect-metadata'
139+
],
140+
excludes: [
141+
'selenium-webdriver',
142+
'rtts_assert',
143+
'zone.js'
144+
],
145+
ignore: [
146+
'rx'
147+
],
148+
dest: CONFIG.dest.benchpress_bundle
149+
}
150+
131151
// ------------
132152
// clean
133153

@@ -151,6 +171,9 @@ gulp.task('build/clean.docs_angular_io', function(done) {
151171
del(CONFIG.dest.docs_angular_io, done);
152172
});
153173

174+
gulp.task('build/clean.benchpress.bundle', function(done) {
175+
del(CONFIG.dest.benchpress_bundle, done);
176+
});
154177

155178
// ------------
156179
// transpile
@@ -888,9 +911,9 @@ gulp.task('bundle.js.sfx.dev.deps', ['bundle.js.sfx.dev'], function() {
888911

889912
gulp.task('bundle.js.deps', ['bundle.js.prod.deps', 'bundle.js.dev.deps', 'bundle.js.min.deps', 'bundle.js.sfx.dev.deps', 'router.bundle.js.dev', 'mock.bundle.js.dev']);
890913

891-
gulp.task('build.js', ['build.js.dev', 'build.js.prod', 'build.js.cjs', 'bundle.js.deps']);
914+
gulp.task('build.js', ['build.js.dev', 'build.js.prod', 'build.js.cjs', 'bundle.js.deps', 'benchpress.bundle']);
892915

893-
gulp.task('clean', ['build/clean.tools', 'build/clean.js', 'build/clean.dart', 'build/clean.docs']);
916+
gulp.task('clean', ['build/clean.tools', 'build/clean.js', 'build/clean.dart', 'build/clean.docs', 'build/clean.benchpress.bundle']);
894917

895918
gulp.task('build', ['build.js', 'build.dart']);
896919

@@ -959,6 +982,18 @@ gulp.task('cleanup.builder', function(done) {
959982
});
960983
});
961984

985+
gulp.task('benchpress.bundle', ['build/clean.benchpress.bundle', 'build.js.cjs'], function(cb) {
986+
bundler.benchpressBundle(
987+
BENCHPRESS_BUNDLE_CONFIG.entries,
988+
BENCHPRESS_BUNDLE_CONFIG.packageJson,
989+
BENCHPRESS_BUNDLE_CONFIG.includes,
990+
BENCHPRESS_BUNDLE_CONFIG.excludes,
991+
BENCHPRESS_BUNDLE_CONFIG.ignore,
992+
BENCHPRESS_BUNDLE_CONFIG.dest,
993+
cb
994+
);
995+
})
996+
962997

963998
// register cleanup listener for ctrl+c/kill used to quit any persistent task (autotest or serve tasks)
964999
process.on('SIGINT', function() {

modules/angular2/src/test_lib/perf_util.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
export {verifyNoBrowserErrors} from './e2e_util';
22

3-
import {bind, Options} from 'benchpress/benchpress';
3+
var benchpress = global['benchpress'];
4+
var bind = benchpress.bind;
5+
var Options = benchpress.Options;
46

57
export function runClickBenchmark(config) {
68
var buttons = config.buttons.map(function(selector) { return $(selector); });

modules/benchpress/index.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,6 @@
1-
require(require('traceur').RUNTIME_PATH);
1+
require('reflect-metadata');
2+
require('traceur/bin/traceur-runtime');
23
module.exports = require('./benchpress.js');
4+
// when bundling benchpress to one file, this is used
5+
// for getting exports out of browserify's scope.
6+
global.__benchpressExports = module.exports;

modules/benchpress/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
"angular2": "<%= packageJson.version %>",
1212
"firefox-profile": "<%= packageJson.devDependencies['firefox-profile'] %>",
1313
"jpm": "<%= packageJson.devDependencies.jpm %>",
14-
"rtts_assert": "<%= packageJson.version %>",
1514
"traceur": "<%= packageJson.dependencies.traceur %>",
16-
"selenium-webdriver": "<%= packageJson.dependencies['selenium-webdriver'] %>"
15+
"selenium-webdriver": "<%= packageJson.dependencies['selenium-webdriver'] %>",
16+
"reflect-metadata": "<%= packageJson.dependencies['reflect-metadata'] %>"
1717
},
1818
"devDependencies": <%= JSON.stringify(packageJson.devDependencies) %>
1919
}

0 commit comments

Comments
 (0)