Skip to content

Conversation

@Vogel612
Copy link
Contributor

Also updates documentation on README to accurately remove net5.0 support implication. Mentions planned dropping of net6 support and planned net9 support.

Also updates documentation on README to accurately remove net5.0 support implication.
Mentions planned dropping of net6 support and planned net9 support.
@Rwing
Copy link
Owner

Rwing commented Dec 1, 2024

We'd better support .NET 9 when releasing the new version, so I will merge the PR first and wait until .NET 9 is supported before publishing the new version.

@Rwing Rwing merged commit 0df1bf2 into Rwing:master Dec 5, 2024
@Rwing
Copy link
Owner

Rwing commented Dec 5, 2024

Thank you very much, I have already released the new version.

@Vogel612
Copy link
Contributor Author

@Rwing sorry, that's on me... this utterly breaks for statements where the Limit and Offset are not applied to the top-level SelectExpression because I made an incorrect change. 0.7.0 should be considered broken and unusable... I am currently working on a fix for the changed net9 paradigm. In the meantime I strongly recommend rolling this back and unpublishing from nuget

}
if (node is SelectExpression se)
{
return VisitSelect(se);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rwing specifically this line is incorrect

@Rwing
Copy link
Owner

Rwing commented Jan 12, 2025

Sorry for my late reply. Has the bug been resolved now? Does the issue only affect the .NET 8 version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants