Compatibility with Swift 4.2 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAu888
reviewed
Sep 18, 2018
Action.xcodeproj/project.pbxproj
Outdated
| PRODUCT_NAME = "$(TARGET_NAME)"; | ||
| SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; | ||
| SWIFT_OPTIMIZATION_LEVEL = "-Onone"; | ||
| SWIFT_SWIFT3_OBJC_INFERENCE = On; |
Contributor
There was a problem hiding this comment.
I think @objc inference should be set to default.
Action.xcodeproj/project.pbxproj
Outdated
| PRODUCT_BUNDLE_IDENTIFIER = com.ashfurrow.Action; | ||
| PRODUCT_NAME = "$(TARGET_NAME)"; | ||
| SKIP_INSTALL = YES; | ||
| SWIFT_SWIFT3_OBJC_INFERENCE = On; |
Member
Author
|
Should be ok now. thank you for the review :) |
ashfurrow
reviewed
Sep 18, 2018
Member
|
Cool, thanks again! I'll get this released to CocoaPods trunk and tag a release on GitHub right away 👍 |
Member
|
Oh boo, I don't have an adequate Xcode version. Let me download it... |
Member
|
Okay all done! Thanks again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also already updated the Podspec to 3.7 for future cocoapods release
Fixes #150. Fixes #152.