Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the auto clicker logic to use bindings instead of explicitly passing values, streamlining how parameters are set.
- Removed legacy parameter parsing from MainPage.xaml.cs and updated AutoClicker.Start() to rely on bound properties.
- Introduced binding-based control for click amounts and delay offsets via AutoClicker properties.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FluentAutoClicker/MainPage.xaml.cs | Removed GetNumberBoxValue and GetIntervalMilliseconds methods; updated event handlers. |
| FluentAutoClicker/Helpers/AutoClicker.cs | Simplified AutoClicker.Start() and AutoClickerThread to use bound properties for settings. |
Files not reviewed (1)
- FluentAutoClicker/MainPage.xaml: Language not supported
| else if (sender.Equals(ClickOffsetCheckBox)) | ||
| { | ||
| ClickOffsetAmount.IsEnabled = ClickOffsetCheckBox.IsChecked == true; | ||
| AutoClicker.clickDelayOffsetEnabled = ClickRepeatCheckBox.IsChecked == true; |
There was a problem hiding this comment.
In the ClickOffsetCheckBox branch, the flag for click delay offset is incorrectly set using ClickRepeatCheckBox.IsChecked instead of ClickOffsetCheckBox.IsChecked. Update this to ensure the correct binding is used.
Suggested change
| AutoClicker.clickDelayOffsetEnabled = ClickRepeatCheckBox.IsChecked == true; | |
| AutoClicker.clickDelayOffsetEnabled = ClickOffsetCheckBox.IsChecked == true; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make auto clicker logic use bindings rather than passing values.
Related Issues
Changes Made
Checklist
Additional Notes