Loom fix-up 2: bypass F-UI's broken Tab M_SETINDEX; reposition ribbon

Two remaining bugs after the first fix-up. Both surfaced clearly from
the user's smoke test:

1. CROSS-REF / PALETTE / ATLAS: "the correct element is selected but
   the tab doesn't switch."

   F-UI's Tab `Case M_SETINDEX` handler does set `Tab\actTabPage`
   internally, but the visible tab does not switch when invoked from
   outside the click path. Suspected cause: the implementation has a
   nested-For-loop iterator with both loops named `tabp`:

       For tabp.TabPage = Each TabPage    ' outer
           If Count = Param1
               Tab\actTabPage = tabp
               For tabp.TabPage = Each TabPage    ' inner, shadows outer
                   ...rebuild every page...
               Next
               Exit

   In non-Strict Blitz, `For X = Each Type` implicitly declares X at
   function scope; the inner re-declaration likely corrupts state in a
   way that nullifies the assignment by the time the next FUI_Update
   renders.

   Bypass M_SETINDEX with `GUE_SetActiveTab(idx)` in CommandPalette.bb
   that does the same work but with distinct iterator names (`probe`
   for the search, `sib` for the rebuild pass), then call it from
   GUE_JumpToEntity in place of `FUI_SendMessage(TabMain, M_SETINDEX,
   tabIdx)`. Still fires the Case TabMain event afterward so the
   existing leave/enter dispatcher runs its hide/show logic.

2. CONSCIENCE RIBBON: Issues button at Y=24 is invisible.

   The tab title strip occupies Y=20..40 (TABPAGE_HEIGHT = 20), so
   Y=24 puts the button behind that strip and behind whatever the
   tabs render. Y=2 (previous attempt) was inside the menu bar's
   click-capture zone. There is no usable top strip in WMain that's
   free of both regions.

   Move to the bottom of WMain instead: rowY = sh - 22. The bottom
   strip is the only horizontal band that has nothing in it on any
   tab. Computed from GraphicsHeight() at Init so it works in any
   window size.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: CoreyRDean

src/Modules/CommandPalette.bb

@@ -357,8 +357,18 @@ Function GUE_JumpToEntity(kind$, refID)
 
     If tabIdx = 0 Or picker = 0 Then Return
 
-    // Visible tab switch + ask the dispatcher to run its leave/enter logic.
-    FUI_SendMessage(TabMain, M_SETINDEX, tabIdx)
+    // Visible tab switch.
+    //
+    // F-UI's M_SETINDEX on Tab does set actTabPage internally, but in
+    // practice the tab does NOT visibly switch when invoked from outside
+    // the normal click path (suspected cause: nested-For-loop iterator
+    // shadowing in F-UI's M_SETINDEX implementation). Bypass M_SETINDEX
+    // and set the active page directly, then rebuild every page so the
+    // visuals refresh on the next render.
+    GUE_SetActiveTab(tabIdx)
+
+    // Ask the existing Case TabMain dispatcher to run its leave/enter
+    // hide/show logic next frame.
     FUI_CreateEvent(TabMain, Str(tabIdx))
 
     // Walk the picker items to find the one whose stored data matches.
@@ -381,3 +391,44 @@ Function GUE_JumpToEntity(kind$, refID)
     // Fire the picker-change event so the downstream handler runs.
     FUI_CreateEvent(picker, "")
 End Function
+
+
+// =============================================================================
+// GUE_SetActiveTab -- direct active-tab assignment, bypassing F-UI's
+// M_SETINDEX whose nested-For-loop iterator shadowing was preventing the
+// visible tab switch when called from outside the click path.
+//
+// Walks every TabPage looking for the (tabIdx)th page owned by TabMain (1-
+// indexed in the same order tabs were created with FUI_TabPage). Assigns it
+// to the Tab's actTabPage and rebuilds all sibling TabPage visuals so the
+// next render shows the new tab active and the others inactive.
+//
+// We use distinct iterator variable names (`probe` then `sib`) instead of
+// reusing one, which was the suspected cause of F-UI's M_SETINDEX failing.
+// =============================================================================
+Function GUE_SetActiveTab(tabIdx)
+    Local TM.Tab = Object.Tab(TabMain)
+    If TM = Null Then Return
+
+    Local count = 1
+    Local target.TabPage = Null
+    For probe.TabPage = Each TabPage
+        If probe\Owner = TM
+            If count = tabIdx
+                target = probe
+                Exit
+            EndIf
+            count = count + 1
+        EndIf
+    Next
+
+    If target = Null Then Return
+
+    TM\actTabPage = target
+
+    For sib.TabPage = Each TabPage
+        If sib\Owner = TM
+            FUI_BuildTabPage sib
+        EndIf
+    Next
+End Function

src/Modules/ConscienceRibbon.bb

@@ -47,11 +47,13 @@ Global CR_Open       = False
 // Layout
 Const CR_RIBBON_W = 460
 Const CR_RIBBON_H = 18
-// Y=24 sits just below the menu bar (which owns Y=0..20). Y=2 was inside the
-// menu bar's mouse-capture zone, which made the Issues button unclickable
-// even though it rendered. Y=24 overlays the right side of the tab title
-// strip, where no tab title extends, so there's no visual collision.
-Const CR_RIBBON_Y = 24
+// Placement history:
+//   Y=2  -- inside menu bar's mouse-capture zone -> Issues button unclickable
+//   Y=24 -- inside tab title strip (Y=20..40)    -> button invisible behind it
+//   Bottom -- the only horizontal strip in WMain with nothing in it on any tab.
+//
+// We compute the actual Y at Init time from GraphicsHeight() so this works
+// whether GUE is launched fullscreen or in a window of any size.
 
 Const CR_FW_W = 600
 Const CR_FW_H = 380
@@ -87,19 +89,19 @@ Function Conscience_Init()
 
     CR_Findings = CreateList()
 
-    // Place the status label in the top-right, in the menu bar's empty real
-    // estate. Owned by WMain so it sits over the menu strip (the menu titles
-    // start at the left and don't extend this far).
+    // Bottom-right of WMain -- the only horizontal strip with nothing in it
+    // on any tab (the menu bar Y=0..20 captures clicks, the tab title strip
+    // Y=20..40 renders on top of overlays, the tab content area has gadgets).
     Local sw = GraphicsWidth()
+    Local sh = GraphicsHeight()
+    Local rowY = sh - CR_RIBBON_H - 4
     Local startX = sw - CR_RIBBON_W - 10
 
-    CR_LblStatus = FUI_Label(WMain, startX, CR_RIBBON_Y + 2, "World ready.", ALIGN_LEFT)
+    CR_LblStatus = FUI_Label(WMain, startX, rowY + 2, "World ready.", ALIGN_LEFT)
 
     // "Issues..." button -- shown at all times so users learn it exists. Use
-    // CS_BORDER (the F-UI default) so the button is visibly clickable; passing
-    // Flags=0 strips the border AND was the suspected cause of the click
-    // hit-test failing.
-    CR_BtnIssues = FUI_Button(WMain, sw - 90, CR_RIBBON_Y, 80, CR_RIBBON_H, "Issues...", "", 0, CS_BORDER)
+    // CS_BORDER (the F-UI default) so the button is visibly clickable.
+    CR_BtnIssues = FUI_Button(WMain, sw - 90, rowY, 80, CR_RIBBON_H, "Issues...", "", 0, CS_BORDER)
 
     // Hidden findings modal.
     Local px = (sw - CR_FW_W) / 2