Skip to content

Adds Import of UIComponent for Routing #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 2, 2024
+11 −5
Merged

Adds Import of UIComponent for Routing #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cda8dac
Update Step 32 README.md
KlattG Oct 1, 2024
ebf6696
Update Step 33 README.md
KlattG Oct 1, 2024
2153431
Update Step 35 README.md
KlattG Oct 1, 2024
8486efe
Update Step 32 Detail.controller.ts
KlattG Oct 1, 2024
7812ae5
Update Step 33 Detail.controller.ts
KlattG Oct 1, 2024
62700ac
Update Step 35 Detail.controller.ts
KlattG Oct 1, 2024
c0c3245
Merge pull request #1 from KlattG/patch-2
KlattG Oct 1, 2024
ce74777
Merge pull request #2 from KlattG/patch-3
KlattG Oct 1, 2024
2ae6144
Merge pull request #3 from KlattG/patch-1
KlattG Oct 1, 2024
4b59f6f
Merge pull request #4 from KlattG/patch-4
KlattG Oct 1, 2024
09123b7
Merge pull request #5 from KlattG/patch-5
KlattG Oct 1, 2024
0a0e071
Merge pull request #6 from KlattG/patch-6
KlattG Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion steps/32/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import Controller from "sap/ui/core/mvc/Controller";
import Component from "../Component";
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
import History from "sap/ui/core/routing/History";
import UIComponent from "sap/ui/core/ UIComponent";

/**
* @namespace ui5.walkthrough.controller
Expand All @@ -62,7 +63,7 @@ export default class Detail extends Controller {
if (previousHash !== undefined) {
window.history.go(-1);
} else {
const router = (this.getOwnerComponent() as Component).getRouter();
const router = UIComponent.getRouterFor(this);
router.navTo("overview", {}, true);
}
}
Expand Down
3 changes: 2 additions & 1 deletion steps/32/webapp/controller/Detail.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Controller from "sap/ui/core/mvc/Controller";
import Component from "../Component";
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
import History from "sap/ui/core/routing/History";
import UIComponent from "sap/ui/core/ UIComponent";

/**
* @namespace ui5.walkthrough.controller
Expand All @@ -27,7 +28,7 @@ export default class Detail extends Controller {
if (previousHash !== undefined) {
window.history.go(-1);
} else {
const router = (this.getOwnerComponent() as Component).getRouter();
const router = UIComponent.getRouterFor(this);
router.navTo("overview", {}, true);
}
}
Expand Down
3 changes: 2 additions & 1 deletion steps/33/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ import Controller from "sap/ui/core/mvc/Controller";
import Component from "../Component";
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
import History from "sap/ui/core/routing/History";
import UIComponent from "sap/ui/core/ UIComponent";
import MessageToast from "sap/m/MessageToast";
import ProductRating, { ProductRating$ChangeEvent } from "../control/ProductRating";
import ResourceBundle from "sap/base/i18n/ResourceBundle";
Expand Down Expand Up @@ -341,7 +342,7 @@ export default class Detail extends Controller {
if (previousHash !== undefined) {
window.history.go(-1);
} else {
const router = (this.getOwnerComponent() as Component).getRouter();
const router = UIComponent.getRouterFor(this);
router.navTo("overview", {}, true);
}
}
Expand Down
3 changes: 2 additions & 1 deletion steps/33/webapp/controller/Detail.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Controller from "sap/ui/core/mvc/Controller";
import Component from "../Component";
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
import History from "sap/ui/core/routing/History";
import UIComponent from "sap/ui/core/ UIComponent";
import MessageToast from "sap/m/MessageToast";
import ProductRating, { ProductRating$ChangeEvent } from "../control/ProductRating";
import ResourceBundle from "sap/base/i18n/ResourceBundle";
Expand Down Expand Up @@ -33,7 +34,7 @@ export default class Detail extends Controller {
if (previousHash !== undefined) {
window.history.go(-1);
} else {
const router = (this.getOwnerComponent() as Component).getRouter();
const router = UIComponent.getRouterFor(this);
router.navTo("overview", {}, true);
}
}
Expand Down
1 change: 1 addition & 0 deletions steps/35/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ import Controller from "sap/ui/core/mvc/Controller";
import Component from "../Component";
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
import History from "sap/ui/core/routing/History";
import UIComponent from "sap/ui/core/ UIComponent";
import MessageToast from "sap/m/MessageToast";
import ProductRating, { ProductRating$ChangeEvent } from "../control/ProductRating";
import ResourceBundle from "sap/base/i18n/ResourceBundle";
Expand Down
3 changes: 2 additions & 1 deletion steps/35/webapp/controller/Detail.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Controller from "sap/ui/core/mvc/Controller";
import Component from "../Component";
import { Route$PatternMatchedEvent } from "sap/ui/core/routing/Route";
import History from "sap/ui/core/routing/History";
import UIComponent from "sap/ui/core/ UIComponent";
import MessageToast from "sap/m/MessageToast";
import ProductRating, { ProductRating$ChangeEvent } from "../control/ProductRating";
import ResourceBundle from "sap/base/i18n/ResourceBundle";
Expand Down Expand Up @@ -39,7 +40,7 @@ export default class Detail extends Controller {
if (previousHash !== undefined) {
window.history.go(-1);
} else {
const router = (this.getOwnerComponent() as Component).getRouter();
const router = UIComponent.getRouterFor(this);
router.navTo("overview", {}, true);
}
}
Expand Down