-
Notifications
You must be signed in to change notification settings - Fork 72
[EDOT] Add new object EDOT #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
i506210
wants to merge
39
commits into
SAP:main
Choose a base branch
from
i506210:feature/edot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+282
−0
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
a8ec8b7
Add files for EDOI & EDOT
i506210 499d83a
React to abaplint
i506210 e1e96b2
React to abaplint
i506210 ecdefa0
Merge branch 'main' into feature/edoi
i506210 3a2e9b9
React to comments from Michael Schneider
i506210 a1ec907
[EDOT] Add files for EDOT
i506210 6ed5d4c
reaction to comments
i506210 4c96d92
delete other object files in PR
i506210 a7025f3
correction
i506210 bdd762a
corrections
i506210 8848e73
Merge branch 'main' into feature/edot
i506210 1c07f07
Remove .DS_Store files
i506210 777533b
corrections
i506210 683a98d
corrections
i506210 6838a10
correction
i506210 ec64a94
correction
i506210 91e81a1
Merge branch 'main' into feature/edot
i506210 f69b218
corrections
i506210 9d3530c
correction to alignment
i506210 7164a56
corrections
i506210 6c1c9d7
corrections
i506210 b742a7f
corrections
i506210 58795a5
corrections
i506210 bc54473
correction
i506210 e90dd95
correction
i506210 013ffe6
correction
i506210 d644706
correction
i506210 48946ba
title changes
i506210 6f7986d
latest changes in label
i506210 33fafac
changes in alignment
i506210 eef4b02
correction to changes
i506210 9922e72
corrections
i506210 83d2cc9
corrections
i506210 5021759
corrections
i506210 4c90f28
correction
i506210 83ba32f
Merge branch 'main' into feature/edot
wurzka ac7f9f9
Fix line ending
wurzka 2219ab3
corrections
i506210 aaed091
Merge branch 'main' into feature/edot
wurzka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # EDOT File Format | ||
|
|
||
| File | Cardinality | Definition | Schema | Example | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.edot.json` | 1 | [`zif_aff_edot_v1.intf.abap`](./type/zif_aff_edot_v1.intf.abap) | [`edot-v1.json`](./edot-v1.json) | [`z_aff_example_edot.edot.json`](./examples/z_aff_example_edot.edot.json) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,153 @@ | ||
| { | ||
| "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edot/edot-v1.json", | ||
| "title": "eDocument Type", | ||
| "description": "eDocument type", | ||
| "type": "object", | ||
| "properties": { | ||
| "formatVersion": { | ||
| "title": "Format Version", | ||
| "description": "Format version", | ||
| "type": "string", | ||
| "const": "1" | ||
| }, | ||
| "header": { | ||
| "title": "Header", | ||
| "description": "Header", | ||
| "type": "object", | ||
| "properties": { | ||
| "description": { | ||
| "title": "Description", | ||
| "description": "eDocument type description", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "originalLanguage": { | ||
| "title": "Original Language", | ||
| "description": "Original language of the eDocument type", | ||
| "type": "string", | ||
| "minLength": 2 | ||
| }, | ||
| "abapLanguageVersion": { | ||
| "title": "ABAP Language Version", | ||
| "description": "ABAP language version", | ||
| "type": "string", | ||
| "enum": [ | ||
| "standard", | ||
| "cloudDevelopment" | ||
| ], | ||
| "enumTitles": [ | ||
| "Standard", | ||
| "ABAP Cloud Development" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "Standard", | ||
| "ABAP cloud development" | ||
| ], | ||
| "default": "standard" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "description", | ||
| "originalLanguage" | ||
| ] | ||
| }, | ||
| "generalInformation": { | ||
| "title": "General Information", | ||
| "description": "General information", | ||
| "type": "object", | ||
| "properties": { | ||
| "table": { | ||
| "title": "eDocument Table", | ||
| "description": "eDocument table", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "preprocessBeforeArchiving": { | ||
| "title": "Preprocess Before Archiving", | ||
| "description": "Preprocess before archiving", | ||
| "type": "boolean" | ||
| }, | ||
| "createdInContingencyMode": { | ||
| "title": "Created in Contingency Mode", | ||
| "description": "Created in contingency mode", | ||
| "type": "boolean" | ||
| }, | ||
| "contingencyEdocType": { | ||
| "title": "Contingency eDocument Type", | ||
| "description": "Contingency eDocument type", | ||
| "type": "string", | ||
| "maxLength": 10 | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| }, | ||
| "readAccessLoggingSettings": { | ||
| "title": "Read Access Logging Settings", | ||
| "description": "Read access logging settings", | ||
| "type": "array", | ||
| "uniqueItems": true, | ||
| "items": { | ||
| "title": "Read Access Loggging Settings", | ||
| "description": "Read access logging settings", | ||
| "type": "object", | ||
| "properties": { | ||
| "fileType": { | ||
| "title": "File Type", | ||
| "description": "File type", | ||
| "type": "string", | ||
| "maxLength": 10 | ||
| }, | ||
| "fileStructure": { | ||
| "title": "File Structure", | ||
| "description": "File structure", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "fileDescription": { | ||
| "title": "File Description", | ||
| "description": "File description", | ||
| "type": "string", | ||
| "maxLength": 60 | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "fileType", | ||
| "fileStructure" | ||
| ] | ||
| } | ||
| }, | ||
| "additionalTables": { | ||
| "title": "Additional Tables", | ||
| "description": "Additional tables", | ||
| "type": "array", | ||
| "uniqueItems": true, | ||
| "items": { | ||
| "title": "Additional Table", | ||
| "description": "Additional eDocument table", | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "title": "Name", | ||
| "description": "eDocument additional table name", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "name" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "formatVersion", | ||
| "header", | ||
| "generalInformation" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "Example EDOT for file formats", | ||
| "originalLanguage": "en" | ||
| }, | ||
| "generalInformation": { | ||
| "table": "EDOFRINV" | ||
| }, | ||
| "readAccessLoggingSettings": [ | ||
| { | ||
| "fileType": "REQUEST", | ||
| "fileStructure": "EDO_FR_INV_INVOICE_TYPE", | ||
| "fileDescription": "eDocument France: Invoice Request" | ||
| } | ||
| ], | ||
| "additionalTables": [ | ||
| { | ||
| "name": "EDOFRINV1" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| "! <p class="shorttext synchronized">AFF for eDocument Type (EDOT)</p> | ||
| "! eDocument types that can be used in eInvoice process | ||
| INTERFACE zif_aff_edot_v1 | ||
| PUBLIC. | ||
|
|
||
| TYPES: | ||
| "! <p class="shorttext">Read Access Loggging Settings</p> | ||
| "! Read access logging settings | ||
| BEGIN OF ty_read_access_logging_setting, | ||
| "! <p class="shorttext">File Type</p> | ||
| "! File type | ||
| "! $required | ||
| file_type TYPE c LENGTH 10, | ||
| "! <p class="shorttext">File Structure</p> | ||
| "! File structure | ||
| "! $required | ||
| file_structure TYPE c LENGTH 30, | ||
| "! <p class="shorttext">File Description</p> | ||
| "! File description | ||
| file_description TYPE c LENGTH 60, | ||
| END OF ty_read_access_logging_setting. | ||
| "! <p class="shorttext">Read Access Logging Settings</p> | ||
| "! Read access logging settings | ||
| TYPES ty_read_acc_logging_settings TYPE SORTED TABLE OF ty_read_access_logging_setting WITH UNIQUE KEY file_type. | ||
| TYPES: | ||
| "! <p class="shorttext">Additional Table</p> | ||
| "! Additional eDocument table | ||
| BEGIN OF ty_additional_table, | ||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Name</p> | ||
| "! eDocument additional table name | ||
| "! $required | ||
| name TYPE zif_aff_types_v1=>ty_object_name_30, | ||
| END OF ty_additional_table. | ||
| "! <p class="shorttext">Additional Tables</p> | ||
| "! Additional eDocument tables | ||
| TYPES ty_additional_tables TYPE SORTED TABLE OF ty_additional_table WITH UNIQUE KEY name. | ||
| TYPES: | ||
| "! <p class="shorttext">General Information</p> | ||
| "! General information | ||
| BEGIN OF ty_general_information, | ||
| "! <p class="shorttext">eDocument Table</p> | ||
| "! eDocument table | ||
| table TYPE zif_aff_types_v1=>ty_object_name_30, | ||
| "! <p class="shorttext">Preprocess Before Archiving</p> | ||
| "! Preprocess before archiving | ||
| preprocess_before_archiving TYPE abap_bool, | ||
| "! <p class="shorttext">Created in Contingency Mode</p> | ||
| "! Created in contingency mode | ||
| created_in_contingency_mode TYPE abap_bool, | ||
| "! <p class="shorttext">Contingency eDocument Type</p> | ||
| "! Contingency eDocument type | ||
| contingency_edoc_type TYPE c LENGTH 10, | ||
| END OF ty_general_information. | ||
| TYPES: | ||
| "! <p class="shorttext">Header for EDOT object</p> | ||
| "! The header for an ABAP main object (without source code) with a description of 30 characters (no key user) | ||
| BEGIN OF ty_header_30_cloud, | ||
| "! <p class="shorttext">Description</p> | ||
| "! eDocument type description | ||
| "! $required | ||
| description TYPE c LENGTH 30, | ||
| "! <p class="shorttext">Original Language</p> | ||
| "! Original language of the eDocument type | ||
| "! $required | ||
| original_language TYPE sy-langu, | ||
| "! <p class="shorttext">ABAP Language Version</p> | ||
| "! ABAP language version | ||
| "! $values {@link zif_aff_types_v1.data:co_abap_language_version_cloud} | ||
| "! $default {@link zif_aff_types_v1.data:co_abap_language_version_cloud.standard} | ||
| abap_language_version TYPE zif_aff_types_v1=>ty_abap_language_version_cloud, | ||
| END OF ty_header_30_cloud. | ||
| TYPES: | ||
| "! <p class="shorttext">eDocument Type</p> | ||
| "! eDocument type | ||
| BEGIN OF ty_main, | ||
| "! <p class="shorttext">Format Version</p> | ||
| "! Format version | ||
| "! $required | ||
| format_version TYPE zif_aff_types_v1=>ty_format_version, | ||
| "! <p class="shorttext">Header</p> | ||
| "! Header | ||
| "! $required | ||
| header TYPE ty_header_30_cloud, | ||
| "! <p class="shorttext">General Information</p> | ||
| "! General information | ||
| "! $required | ||
| general_information TYPE ty_general_information, | ||
| "! <p class="shorttext">Read Access Logging Settings</p> | ||
| "! Read access logging settings | ||
| read_access_logging_settings TYPE ty_read_acc_logging_settings, | ||
| "! <p class="shorttext">Additional Tables</p> | ||
| "! Additional tables | ||
| additional_tables TYPE ty_additional_tables, | ||
| END OF ty_main. | ||
| ENDINTERFACE. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "AFF for eDocument Type (EDOT)", | ||
| "originalLanguage": "en" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are file types defined by a hard set of values? If so, we could use an enumeration here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not hard set of values but coming from check table, we need to have value help instead fixed domain, I think it will be covered during development