Conversation
fc93e02 to
d054db7
Compare
veredcon
left a comment
There was a problem hiding this comment.
General Comment:
The following plugins are consumed in the code snippet:
"@sap-devx/inquirer-gui-file-browser-plugin";
"@sap-devx/inquirer-gui-folder-browser-plugin";
"@sap-devx/inquirer-gui-radio-plugin";
"@sap-devx/inquirer-gui-login-plugin";
"@sap-devx/inquirer-gui-tiles-plugin";
"@sap-devx/inquirer-gui-label-plugin";
And also the Form itself and its build in plugins (input, list etc.)
In order to cover yourself 100% regarding style - I think it is better to add the missing controls in the example/vscode-snippet-contrib in the createCodeSnippetQuestions and create questions of more input types...(except the "list", "input", "file-browser" and "checkbox" that exist).
The build in Form types:
https://github.com/SAP/inquirer-gui/blob/master/packages/inquirer-gui/src/Plugins.js#L19
label: https://github.com/SAP/inquirer-gui/blob/master/packages/label-plugin/src/index.js#L8
folder: https://github.com/SAP/inquirer-gui/blob/master/packages/folder-browser-plugin/src/index.js#L8
login:
https://github.com/SAP/inquirer-gui/blob/master/packages/login-plugin/src/index.js#L8
tiles: https://github.com/SAP/inquirer-gui/blob/master/packages/tiles-plugin/src/index.js#L8
From what I see when I run the vscode-contrib locally - the padding before the text starts in some of the fields are too much:
but this is just one example... we must have more controls to have the full picture.
Also when I run it locally I can see the Create Launch Configuraton form as you see in the screenshot above, however when I take this vsix to BAS it is not being activated and I get this error:
I don't know when it has been stopped working and I believe it is not related to your change but I think it is worth looking at it as part of this change if we want to compare how it looks in BAS..


No description provided.