Skip to content

feat: migrating to Vue3#280

Merged
nprijic merged 5 commits intomasterfrom
Vue3
Jan 30, 2024
Merged

feat: migrating to Vue3#280
nprijic merged 5 commits intomasterfrom
Vue3

Conversation

@nprijic
Copy link
Copy Markdown
Contributor

@nprijic nprijic commented Jan 8, 2024

No description provided.

@nprijic nprijic force-pushed the Vue3 branch 3 times, most recently from fc93e02 to d054db7 Compare January 10, 2024 13:54
Copy link
Copy Markdown
Member

@veredcon veredcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General Comment:
The following plugins are consumed in the code snippet:
"@sap-devx/inquirer-gui-file-browser-plugin";
"@sap-devx/inquirer-gui-folder-browser-plugin";
"@sap-devx/inquirer-gui-radio-plugin";
"@sap-devx/inquirer-gui-login-plugin";
"@sap-devx/inquirer-gui-tiles-plugin";
"@sap-devx/inquirer-gui-label-plugin";
And also the Form itself and its build in plugins (input, list etc.)

In order to cover yourself 100% regarding style - I think it is better to add the missing controls in the example/vscode-snippet-contrib in the createCodeSnippetQuestions and create questions of more input types...(except the "list", "input", "file-browser" and "checkbox" that exist).

The build in Form types:
https://github.com/SAP/inquirer-gui/blob/master/packages/inquirer-gui/src/Plugins.js#L19

label: https://github.com/SAP/inquirer-gui/blob/master/packages/label-plugin/src/index.js#L8

folder: https://github.com/SAP/inquirer-gui/blob/master/packages/folder-browser-plugin/src/index.js#L8

login:
https://github.com/SAP/inquirer-gui/blob/master/packages/login-plugin/src/index.js#L8

tiles: https://github.com/SAP/inquirer-gui/blob/master/packages/tiles-plugin/src/index.js#L8

From what I see when I run the vscode-contrib locally - the padding before the text starts in some of the fields are too much:

image

but this is just one example... we must have more controls to have the full picture.

Also when I run it locally I can see the Create Launch Configuraton form as you see in the screenshot above, however when I take this vsix to BAS it is not being activated and I get this error:

image

I don't know when it has been stopped working and I believe it is not related to your change but I think it is worth looking at it as part of this change if we want to compare how it looks in BAS..

Comment thread packages/backend/webpack.config.js
Comment thread packages/frontend/jest.config.js
Comment thread packages/frontend/src/main.js
Comment thread packages/frontend/test/App.spec.js
Comment thread packages/frontend/test/App.spec.js
Comment thread packages/frontend/test/App.spec.js
@nprijic nprijic removed the request for review from alex-gilin January 29, 2024 06:39
@nprijic nprijic merged commit 67670a6 into master Jan 30, 2024
@nprijic nprijic deleted the Vue3 branch January 30, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants