Skip to content

Refactor handling of references #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Refactor handling of references #240

merged 1 commit into from
Feb 26, 2025
+70 −167

Conversation

@cbarbian-sap
Copy link
Contributor

@cbarbian-sap cbarbian-sap commented Feb 26, 2025 •
edited
Loading

This PR is mainly about refactoring.

But maybe there are two interesting changes:

  • It is now written in stone: hooks must not change the component's metadata or spec; this was actually always clear, but now it is really explicitly forbidden
  • The component digest (which is for example passed to generators and influencing the status.ProcessingDigest is now considering the metadata.generation of the component

@cbarbian-sap cbarbian-sap marked this pull request as draft February 26, 2025 22:52
@cbarbian-sap cbarbian-sap marked this pull request as ready for review February 26, 2025 23:01
@cbarbian-sap cbarbian-sap merged commit 36a1378 into main Feb 26, 2025
8 checks passed
@cbarbian-sap cbarbian-sap deleted the refactor-references branch February 26, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbarbian-sap