Fix dependency on old requests #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 855c090 in release 0.8.0 introduced use of the `~=` operator to declare package dependencies. Sadly, this introduced a bug where now the package depended on `requests >= 2.20.0; requests < 2.21.0` due to the way the "compatible release operator" is specified in PEP-440. The notion of "compatible release" in PEP-440 thus does not strictly follow semantic versioning. This commit updates the dependencies to once again allow updates to any minor version.
karthikmswamy
approved these changes
Jun 14, 2021
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
This is nice! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 855c090 in release 0.8.0 introduced use of the
~=operator to declare package dependencies. Sadly, this introduced a bug where now the package depended onrequests >= 2.20.0; requests < 2.21.0dueto the way the "compatible release operator" is specified in PEP-440.
The notion of "compatible release" in PEP-440 thus does not strictly follow semantic versioning.
This commit updates the dependencies to once again allow updates to any minor version.