Adding GitHub Actions workflow config file #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-Travis-CI-to-Github-actions
…m-Travis-CI-to-Github-actions
Shegox
requested changes
Feb 20, 2025
Shegox
left a comment
Shegox
left a comment
There was a problem hiding this comment.
I have a few things which could be improved and a few nit picks, which you might want to take a look at.
Shegox
reviewed
Feb 20, 2025
Shegox
approved these changes
Feb 24, 2025
| run: pipx run build --sdist --wheel | ||
|
|
||
| - name: Deploy release to PyPI | ||
| uses: pypa/gh-action-pypi-publish@release/v1 # Uses OIDC/Workload identities and doesn't require a token No newline at end of file |
There was a problem hiding this comment.
Just to be sure, did you make sure to add the trusted publisher configuration in Pypi?
(https://docs.pypi.org/trusted-publishers/adding-a-publisher/)
eksutter
reviewed
Feb 24, 2025
Contributor
eksutter
left a comment
eksutter
left a comment
There was a problem hiding this comment.
Thanks! I have only a minor question to the used patch versions of Python. I would perhaps drop the patch version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding GitHub Actions workflow config file to Move-DAR-SDK-from Travis CI to Github actions.
Checks: